Refactor scanopy-install.sh for server setup

Updated installation script to configure Scanopy server and removed daemon configuration section.

CHANGELOG.md

@@ -543,6 +543,30 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
 </details>
 
+## 2026-09-15
+
+### 🆕 New Scripts
+
+  - valhalla ([#17231](https://github.com/community-scripts/ProxmoxVE/pull/17231))
+
+### 🚀 Updated Scripts
+
+  - #### 🐞 Bug Fixes
+
+    - tracearr: copy packages/emails into the deploy tree [@connorgallopo](https://github.com/connorgallopo) ([#17268](https://github.com/community-scripts/ProxmoxVE/pull/17268))
+    - Immich: Pin to v3.2.1 [@vhsdream](https://github.com/vhsdream) ([#17264](https://github.com/community-scripts/ProxmoxVE/pull/17264))
+
+### 💾 Core
+
+  - Add vm_extract_image, which two VM scripts already call [@MickLesk](https://github.com/MickLesk) ([core#40](https://github.com/community-scripts/core/pull/40))
+- Releases: rank releases on their numbers, not on sort -V over the raw tag [@MickLesk](https://github.com/MickLesk) ([core#39](https://github.com/community-scripts/core/pull/39))
+
+### 🧰 Tools
+
+  - #### 🔧 Refactor
+
+    - Refactor: monitor-all (decide on flag values, not on key presence) [@MickLesk](https://github.com/MickLesk) ([#17261](https://github.com/community-scripts/ProxmoxVE/pull/17261))
+
 ## 2026-09-14
 
 ### 🆕 New Scripts

ct/headers/valhalla

@@ -0,0 +1,6 @@
+ _    __      ____          ____     
+| |  / /___ _/ / /_  ____ _/ / /___ _
+| | / / __ `/ / __ \/ __ `/ / / __ `/
+| |/ / /_/ / / / / / /_/ / / / /_/ / 
+|___/\__,_/_/_/ /_/\__,_/_/_/\__,_/  
+                                     

ct/immich.sh

@@ -112,7 +112,7 @@ EOF
     msg_ok "Image-processing libraries up to date"
   fi
 
-  RELEASE="v3.2.0"
+  RELEASE="v3.2.1"
   if check_for_gh_release "Immich" "immich-app/immich" "${RELEASE}" "each release is tested individually before the version is updated. Please do not open issues for this"; then
     if [[ $(cat ~/.immich) > "2.5.1" ]]; then
       msg_info "Enabling Maintenance Mode"

ct/scanopy.sh

@@ -32,41 +32,25 @@ function update_script() {
     exit
   fi
 
-  if check_for_gh_release "Scanopy" "scanopy/scanopy"; then
+  if check_for_gh_release "scanopy-server" "scanopy/scanopy"; then
     msg_info "Stopping services"
     systemctl stop scanopy-server
     [[ -f /etc/systemd/system/scanopy-daemon.service ]] && systemctl stop scanopy-daemon
     msg_ok "Stopped services"
 
-    create_backup /opt/scanopy/.env /opt/scanopy/oidc.toml
-
-    CLEAN_INSTALL=1 fetch_and_deploy_gh_release "Scanopy" "scanopy/scanopy" "tarball" "latest" "/opt/scanopy"
-
-    restore_backup
-
-    ensure_dependencies pkg-config libssl-dev
-    TOOLCHAIN="$(grep "channel" /opt/scanopy/backend/rust-toolchain.toml | awk -F\" '{print $2}')"
-    RUST_TOOLCHAIN=$TOOLCHAIN setup_rust
-
     if ! grep -q "PUBLIC_URL" /opt/scanopy/.env; then
-      sed -i "\|_PATH=|a\\scanopy_PUBLIC_URL=http://${LOCAL_IP}:60072" /opt/scanopy/.env
+      sed -i "\|_PATH=|a\\SCANOPY_PUBLIC_URL=http://${LOCAL_IP}:60072" /opt/scanopy/.env
     fi
     sed -i 's|_TARGET=.*$|_URL=http://127.0.0.1:60072|' /opt/scanopy/.env
+    sed -i '/^SCANOPY_WEB_EXTERNAL_PATH=/d' /opt/scanopy/.env
+    sed -i 's|^WorkingDirectory=/opt/scanopy/backend$|WorkingDirectory=/opt/scanopy|' /etc/systemd/system/scanopy-server.service
+    systemctl daemon-reload
 
-    msg_info "Building Scanopy Server (patience)"
-    cd /opt/scanopy/backend
-    CARGO_BUILD_JOBS="$(get_parallel_jobs)" $STD cargo build --release --bin server --bin generate-fixtures
-    $STD ./target/release/generate-fixtures --output-dir /opt/scanopy/ui/src/lib/data
-    mv ./target/release/server /usr/bin/scanopy-server
-    msg_ok "Built Scanopy Server"
+    cp -f /usr/bin/scanopy-server /usr/bin/scanopy-server.bak 2>/dev/null || true
 
-    msg_info "Creating frontend UI"
-    export PUBLIC_SERVER_HOSTNAME=default
-    export PUBLIC_SERVER_PORT=""
-    cd /opt/scanopy/ui
-    $STD npm ci --no-fund --no-audit
-    $STD npm run build
-    msg_ok "Created frontend UI"
+    fetch_and_deploy_gh_release "scanopy-server" "scanopy/scanopy" "singlefile" "latest" "/usr/bin" "scanopy-server-linux-$(arch_resolve)"
+
+    rm -rf /opt/scanopy/backend /opt/scanopy/ui
 
     if [[ -f /etc/systemd/system/scanopy-daemon.service ]]; then
       fetch_and_deploy_gh_release "Scanopy Daemon" "scanopy/scanopy" "singlefile" "latest" "/usr/local/bin" "scanopy-daemon-linux-$(arch_resolve)"
@@ -81,6 +65,22 @@ function update_script() {
 
     msg_info "Starting services"
     systemctl start scanopy-server
+    healthy=0
+    for _ in {1..30}; do
+      if curl -fsS -o /dev/null http://127.0.0.1:60072/api/health 2>/dev/null; then
+        healthy=1
+        break
+      fi
+      sleep 2
+    done
+    if [[ "$healthy" -ne 1 ]]; then
+      systemctl stop scanopy-server
+      [[ -f /usr/bin/scanopy-server.bak ]] && mv -f /usr/bin/scanopy-server.bak /usr/bin/scanopy-server
+      systemctl start scanopy-server
+      msg_error "New server did not answer /api/health, restored the previous binary"
+      exit 1
+    fi
+    rm -f /usr/bin/scanopy-server.bak
     [[ -f /etc/systemd/system/scanopy-daemon.service ]] && systemctl start scanopy-daemon
     msg_ok "Updated successfully!"
   fi

ct/tracearr.sh

@@ -124,7 +124,7 @@ EOF
     $STD pnpm turbo telemetry disable
     $STD pnpm turbo run build --no-daemon --filter=@tracearr/shared --filter=@tracearr/server --filter=@tracearr/web
     rm -rf /opt/tracearr
-    mkdir -p /opt/tracearr/{packages/shared,apps/server,apps/web,apps/server/src/db}
+    mkdir -p /opt/tracearr/{packages/shared,packages/emails,apps/server,apps/web,apps/server/src/db}
     cp -rf package.json /opt/tracearr/
     cp -rf pnpm-workspace.yaml /opt/tracearr/
     cp -rf pnpm-lock.yaml /opt/tracearr/
@@ -134,6 +134,8 @@ EOF
     cp -rf apps/web/dist /opt/tracearr/apps/web/dist
     cp -rf packages/shared/package.json /opt/tracearr/packages/shared/
     cp -rf packages/shared/dist /opt/tracearr/packages/shared/dist
+    cp -rf packages/emails/package.json /opt/tracearr/packages/emails/
+    cp -rf packages/emails/dist /opt/tracearr/packages/emails/dist
     cp -rf apps/server/src/db/migrations /opt/tracearr/apps/server/src/db/migrations
     cp -rf data /opt/tracearr/data
     mkdir -p /opt/tracearr/data/image-cache

ct/valhalla.sh

@@ -0,0 +1,104 @@
+#!/usr/bin/env bash
+_CS_DEFAULT_URL="https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main"
+_cs_boot="${COMMUNITY_SCRIPTS_CORE_DIR:-$(dirname "${BASH_SOURCE[0]}")/../../core}/core/build.func"
+source "$_cs_boot" 2>/dev/null || source <(curl -fsSL "${COMMUNITY_SCRIPTS_CORE_URL:-https://raw.githubusercontent.com/community-scripts/core/main}/core/build.func")
+# Copyright (c) 2021-2026 community-scripts ORG
+# Author: CrazyWolf13
+# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
+# Source: https://github.com/valhalla/valhalla
+
+APP="Valhalla"
+var_tags="${var_tags:-mapping;routing}"
+var_cpu="${var_cpu:-6}"
+var_ram="${var_ram:-6144}"
+var_disk="${var_disk:-24}"
+var_os="${var_os:-debian}"
+var_version="${var_version:-13}"
+var_arm64="${var_arm64:-yes}"
+var_unprivileged="${var_unprivileged:-1}"
+
+header_info "$APP"
+variables
+color
+catch_errors
+
+function update_script() {
+  header_info
+  check_container_storage
+  check_container_resources
+
+  if [[ ! -f /etc/systemd/system/valhalla.service ]]; then
+    msg_error "No ${APP} Installation Found!"
+    exit
+  fi
+
+  if check_for_gh_release "prime_server" "kevinkreiser/prime_server"; then
+    RELEASE="$CHECK_UPDATE_RELEASE"
+
+    msg_info "Stopping Service"
+    systemctl stop valhalla
+    msg_ok "Stopped Service"
+
+    msg_info "Building prime_server ${RELEASE} (Patience)"
+    rm -rf /tmp/prime_server
+    $STD git clone --recurse-submodules --depth 1 --branch "$RELEASE" https://github.com/kevinkreiser/prime_server /tmp/prime_server
+    cd /tmp/prime_server
+    $STD ./autogen.sh
+    $STD ./configure
+    $STD make -j"$(nproc)"
+    $STD make install
+    cd /
+    rm -rf /tmp/prime_server
+    ldconfig
+    echo "${RELEASE#v}" >"$HOME/.prime_server"
+    msg_ok "Built prime_server ${RELEASE}"
+
+    msg_info "Starting Service"
+    systemctl start valhalla
+    msg_ok "Started Service"
+  fi
+
+  if check_for_gh_release "valhalla" "valhalla/valhalla"; then
+    RELEASE="$CHECK_UPDATE_RELEASE"
+
+    msg_info "Stopping Service"
+    systemctl stop valhalla
+    msg_ok "Stopped Service"
+
+    msg_info "Fetching Valhalla ${RELEASE} (Patience)"
+    rm -rf /opt/valhalla
+    $STD git clone --recurse-submodules --depth 1 --branch "$RELEASE" https://github.com/valhalla/valhalla.git /opt/valhalla
+    msg_ok "Fetched Valhalla ${RELEASE}"
+
+    msg_info "Compiling Valhalla ${RELEASE} (this takes 20-45+ minutes, be patient)"
+    MEM_MB=$(awk '/MemTotal/{print int($2/1024)}' /proc/meminfo)
+    BUILD_JOBS=$((MEM_MB / 2000))
+    [[ $BUILD_JOBS -lt 1 ]] && BUILD_JOBS=1
+    [[ $BUILD_JOBS -gt $(nproc) ]] && BUILD_JOBS=$(nproc)
+    cd /opt/valhalla
+    $STD cmake -B build -DCMAKE_BUILD_TYPE=Release -DENABLE_PYTHON_BINDINGS=OFF -DENABLE_TESTS=OFF -DENABLE_SINGLE_FILES_WERROR=OFF
+    $STD cmake --build build -- -j"$BUILD_JOBS"
+    $STD cmake --install build
+    ldconfig
+    echo "${RELEASE#v}" >"$HOME/.valhalla"
+    msg_ok "Compiled Valhalla ${RELEASE}"
+
+    msg_info "Starting Service"
+    systemctl start valhalla
+    msg_ok "Started Service"
+  fi
+
+  msg_ok "Updated Successfully!\n"
+  exit
+}
+
+start
+build_container
+description
+
+msg_ok "Completed Successfully!\n"
+echo -e "${CREATING}${GN}${APP} setup has been successfully initialized!${CL}"
+echo -e "${INFO}${YW}Access it using the following URL:${CL}"
+echo -e "${GATEWAY}${BGN}http://${IP}:8002/status${CL}"
+echo -e "${INFO}${YW}No routing tiles are built yet. Build them for your region with:${CL}"
+echo -e "${TAB}${BGN}/opt/valhalla_data/build-tiles.sh https://download.geofabrik.de/<continent>/<region>-latest.osm.pbf${CL}"

install/immich-install.sh

@@ -353,7 +353,7 @@ ML_DIR="${APP_DIR}/machine-learning"
 GEO_DIR="${INSTALL_DIR}/geodata"
 mkdir -p {"${APP_DIR}","${UPLOAD_DIR}","${GEO_DIR}","${INSTALL_DIR}"/cache}
 
-fetch_and_deploy_gh_release "Immich" "immich-app/immich" "tarball" "v3.2.0" "$SRC_DIR"
+fetch_and_deploy_gh_release "Immich" "immich-app/immich" "tarball" "v3.2.1" "$SRC_DIR"
 PNPM_VERSION="$(jq -r '.packageManager | split("@")[1] | split("+")[0]' ${SRC_DIR}/package.json)"
 export COREPACK_ENABLE_DOWNLOAD_PROMPT=0
 NODE_VERSION="24" NODE_MODULE="corepack" setup_nodejs

install/scanopy-install.sh

@@ -13,40 +13,15 @@ setting_up_container
 network_check
 update_os
 
-msg_info "Installing Dependencies"
-$STD apt install -y \
-  build-essential \
-  libssl-dev \
-  pkg-config
-msg_ok "Installed Dependencies"
-
 PG_VERSION=17 setup_postgresql
-NODE_VERSION="24" setup_nodejs
 PG_DB_NAME="scanopy_db" PG_DB_USER="scanopy" PG_DB_GRANT_SUPERUSER="true" setup_postgresql_db
-fetch_and_deploy_gh_release "Scanopy" "scanopy/scanopy" "tarball" "latest" "/opt/scanopy"
-TOOLCHAIN="$(grep "channel" /opt/scanopy/backend/rust-toolchain.toml | awk -F\" '{print $2}')"
-RUST_TOOLCHAIN=$TOOLCHAIN setup_rust
+fetch_and_deploy_gh_release "scanopy" "scanopy/scanopy" "singlefile" "latest" "/usr/bin" "scanopy-server-linux-$(arch_resolve)"
 
-msg_info "Building Scanopy Server (patience)"
-cd /opt/scanopy/backend
-CARGO_BUILD_JOBS="$(get_parallel_jobs)" $STD cargo build --release --bin server --bin generate-fixtures
-$STD ./target/release/generate-fixtures --output-dir /opt/scanopy/ui/src/lib/data
-mv ./target/release/server /usr/bin/scanopy-server
-msg_ok "Built Scanopy Server"
-
-msg_info "Creating frontend UI"
-export PUBLIC_SERVER_HOSTNAME=default
-export PUBLIC_SERVER_PORT=""
-cd /opt/scanopy/ui
-$STD npm ci --no-fund --no-audit
-$STD npm run build
-msg_ok "Created frontend UI"
-
-msg_info "Configuring server for first-run"
+msg_info "Configuring Scanopy"
+mkdir -p /opt/scanopy
 cat <<EOF >/opt/scanopy/.env
 ### - SERVER
 SCANOPY_DATABASE_URL=postgresql://$PG_DB_USER:$PG_DB_PASS@localhost:5432/$PG_DB_NAME
-SCANOPY_WEB_EXTERNAL_PATH="/opt/scanopy/ui/build"
 SCANOPY_PUBLIC_URL=http://${LOCAL_IP}:60072
 SCANOPY_SERVER_PORT=60072
 SCANOPY_LOG_LEVEL=info
@@ -73,7 +48,9 @@ SCANOPY_HEARTBEAT_INTERVAL=30
 
 ### - see https://github.com/scanopy/scanopy/blob/main/docs/CONFIGURATION.md for more options
 EOF
+msg_ok "Configured Scanopy"
 
+msg_info "Creating Service"
 cat <<EOF >/etc/systemd/system/scanopy-server.service
 [Unit]
 Description=Scanopy Network Discovery Server
@@ -81,7 +58,7 @@ After=network.target postgresql.service
 
 [Service]
 Type=simple
-WorkingDirectory=/opt/scanopy/backend
+WorkingDirectory=/opt/scanopy
 EnvironmentFile=/opt/scanopy/.env
 ExecStart=/usr/bin/scanopy-server
 Restart=always
@@ -92,43 +69,8 @@ StandardError=journal
 [Install]
 WantedBy=multi-user.target
 EOF
-
 systemctl enable -q --now scanopy-server
-
-# Creating short script to configure scanopy-daemon
-# cat <<EOF >~/configure_daemon.sh
-# #!/usr/bin/env bash
-#
-# echo "Auto-configuring integrated daemon..."
-#
-# NETWORK_ID="\$(sudo -u postgres psql -1 -t -d "${PG_DB_NAME}" -c 'SELECT id FROM networks;')"
-# API_KEY="\$(sudo -u postgres psql -1 -t -d "${PG_DB_NAME}" -c 'SELECT key FROM api_keys;')"
-#
-# cat <<END >/etc/systemd/system/scanopy-daemon.service
-# [Unit]
-# Description=Scanopy Network Discovery Daemon
-# After=network-online.target
-# Wants=network-online.target
-#
-# [Service]
-# Type=simple
-# User=root
-# ExecStart=/usr/bin/scanopy-daemon --server-url http://127.0.0.1:60072 --network-id \${NETWORK_ID} --daemon-api-key \${API_KEY} --mode push
-# Restart=always
-# RestartSec=10
-# StandardOutput=journal
-# StandardError=journal
-#
-# [Install]
-# WantedBy=multi-user.target
-# END
-#
-# systemctl enable -q --now scanopy-daemon
-# echo "Scanopy daemon configured and running"
-#
-# EOF
-# chmod +x ~/configure_daemon.sh
-msg_ok "Scanopy server running - please create an account, daemon API key and daemon in the Scanopy UI."
+msg_ok "Created Service"
 
 motd_ssh
 customize

install/tracearr-install.sh

@@ -67,7 +67,7 @@ cd /opt/tracearr.build
 $STD pnpm install --frozen-lockfile --force
 $STD pnpm turbo telemetry disable
 $STD pnpm turbo run build --no-daemon --filter=@tracearr/shared --filter=@tracearr/server --filter=@tracearr/web
-mkdir -p /opt/tracearr/{packages/shared,apps/server,apps/web,apps/server/src/db}
+mkdir -p /opt/tracearr/{packages/shared,packages/emails,apps/server,apps/web,apps/server/src/db}
 cp -rf package.json /opt/tracearr/
 cp -rf pnpm-workspace.yaml /opt/tracearr/
 cp -rf pnpm-lock.yaml /opt/tracearr/
@@ -77,6 +77,8 @@ cp -rf apps/server/scripts /opt/tracearr/apps/server/scripts
 cp -rf apps/web/dist /opt/tracearr/apps/web/dist
 cp -rf packages/shared/package.json /opt/tracearr/packages/shared/
 cp -rf packages/shared/dist /opt/tracearr/packages/shared/dist
+cp -rf packages/emails/package.json /opt/tracearr/packages/emails/
+cp -rf packages/emails/dist /opt/tracearr/packages/emails/dist
 cp -rf apps/server/src/db/migrations /opt/tracearr/apps/server/src/db/migrations
 cp -rf data /opt/tracearr/data
 mkdir -p /opt/tracearr/data/image-cache

install/valhalla-install.sh

@@ -0,0 +1,187 @@
+#!/usr/bin/env bash
+
+# Copyright (c) 2021-2026 community-scripts ORG
+# Author: CrazyWolf13
+# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
+# Source: https://github.com/valhalla/valhalla
+
+source /dev/stdin <<<"$FUNCTIONS_FILE_PATH"
+color
+verb_ip6
+catch_errors
+setting_up_container
+network_check
+update_os
+
+msg_info "Installing Dependencies"
+$STD apt install -y \
+  autoconf \
+  automake \
+  ccache \
+  clang \
+  clang-tidy \
+  coreutils \
+  cmake \
+  g++ \
+  gcc \
+  git \
+  jq \
+  lcov \
+  libboost-all-dev \
+  libcurl4-openssl-dev \
+  libczmq-dev \
+  libgdal-dev \
+  libgeos++-dev \
+  libgeos-dev \
+  libluajit-5.1-dev \
+  liblz4-dev \
+  libprotobuf-dev \
+  libspatialite-dev \
+  libsqlite3-dev \
+  libsqlite3-mod-spatialite \
+  libtool \
+  libzmq3-dev \
+  lld \
+  locales \
+  luajit \
+  make \
+  osmium-tool \
+  parallel \
+  pkgconf \
+  protobuf-compiler \
+  python3-all-dev \
+  python3-shapely \
+  python3-requests \
+  python3-pip \
+  spatialite-bin \
+  unzip \
+  zlib1g-dev
+msg_ok "Installed Dependencies"
+
+PRIME_SERVER_RELEASE=$(get_latest_github_release "kevinkreiser/prime_server" "false")
+msg_info "Building prime_server ${PRIME_SERVER_RELEASE} (Patience)"
+$STD git clone --recurse-submodules --depth 1 --branch "$PRIME_SERVER_RELEASE" https://github.com/kevinkreiser/prime_server /tmp/prime_server
+cd /tmp/prime_server
+$STD ./autogen.sh
+$STD ./configure
+$STD make -j"$(nproc)"
+$STD make install
+cd /
+rm -rf /tmp/prime_server
+echo "${PRIME_SERVER_RELEASE#v}" >"$HOME/.prime_server"
+msg_ok "Built prime_server"
+
+RELEASE=$(get_latest_github_release "valhalla/valhalla" "false")
+msg_info "Cloning Valhalla ${RELEASE} (Patience)"
+mkdir -p /opt/valhalla
+$STD git clone --recurse-submodules --depth 1 --branch "$RELEASE" https://github.com/valhalla/valhalla.git /opt/valhalla
+msg_ok "Cloned Valhalla ${RELEASE}"
+
+msg_info "Compiling Valhalla ${RELEASE} (this takes 20-45+ minutes, be patient)"
+MEM_MB=$(awk '/MemTotal/{print int($2/1024)}' /proc/meminfo)
+BUILD_JOBS=$((MEM_MB / 2000))
+[[ $BUILD_JOBS -lt 1 ]] && BUILD_JOBS=1
+[[ $BUILD_JOBS -gt $(nproc) ]] && BUILD_JOBS=$(nproc)
+cd /opt/valhalla
+$STD cmake -B build -DCMAKE_BUILD_TYPE=Release -DENABLE_PYTHON_BINDINGS=OFF -DENABLE_TESTS=OFF -DENABLE_SINGLE_FILES_WERROR=OFF
+$STD cmake --build build -- -j"$BUILD_JOBS"
+$STD cmake --install build
+ldconfig
+echo "${RELEASE#v}" >"$HOME/.valhalla"
+msg_ok "Compiled Valhalla ${RELEASE}"
+
+msg_info "Configuring Valhalla"
+useradd --system --no-create-home --shell /usr/sbin/nologin valhalla 2>/dev/null || true
+mkdir -p /opt/valhalla_data/{valhalla_tiles,pbf}
+THREADS=$(nproc)
+valhalla_build_config \
+  --mjolnir-tile-dir /opt/valhalla_data/valhalla_tiles \
+  --mjolnir-tile-extract /opt/valhalla_data/valhalla_tiles.tar \
+  --mjolnir-admin /opt/valhalla_data/admins.sqlite \
+  --mjolnir-timezone /opt/valhalla_data/timezones.sqlite \
+  --mjolnir-concurrency "$THREADS" \
+  >/opt/valhalla_data/valhalla.json
+
+cat <<'EOF' >/opt/valhalla_data/build-tiles.sh
+#!/usr/bin/env bash
+# (Re)builds Valhalla routing tiles from one or more OSM extracts.
+# Usage: build-tiles.sh <pbf-url-or-path> [<pbf-url-or-path> ...]
+# Example: build-tiles.sh https://download.geofabrik.de/europe/germany-latest.osm.pbf
+set -euo pipefail
+export PATH="/usr/local/bin:/usr/local/sbin:$PATH"
+if [[ $# -eq 0 ]]; then
+  echo "Usage: $0 <pbf-url-or-path> [<pbf-url-or-path> ...]" >&2
+  exit 1
+fi
+
+DATA_DIR=/opt/valhalla_data
+CONFIG="$DATA_DIR/valhalla.json"
+mkdir -p "$DATA_DIR/pbf"
+
+FILES=()
+for src in "$@"; do
+  if [[ "$src" == http://* || "$src" == https://* ]]; then
+    fname="$DATA_DIR/pbf/$(basename "$src")"
+    echo "Downloading $src"
+    curl -fL --progress-bar -o "$fname" "$src"
+  else
+    fname="$src"
+  fi
+  FILES+=("$fname")
+done
+
+systemctl stop valhalla
+
+echo "Building admin database"
+valhalla_build_admins --config "$CONFIG" "${FILES[@]}"
+
+echo "Building timezone database"
+valhalla_build_timezones >"$DATA_DIR/timezones.sqlite"
+
+echo "Building initial tile graph"
+valhalla_build_tiles -c "$CONFIG" -e build "${FILES[@]}"
+
+echo "Enhancing tile graph"
+valhalla_build_tiles -c "$CONFIG" -s enhance "${FILES[@]}"
+
+echo "Packing tiles into a single extract"
+valhalla_build_extract -c "$CONFIG" -v
+
+chown -R valhalla:valhalla "$DATA_DIR"
+systemctl start valhalla
+echo "Done. Tiles are in $DATA_DIR/valhalla_tiles (and packed at $DATA_DIR/valhalla_tiles.tar)."
+EOF
+chmod +x /opt/valhalla_data/build-tiles.sh
+chown -R valhalla:valhalla /opt/valhalla_data
+msg_ok "Configured Valhalla"
+
+msg_info "Creating Service"
+cat <<EOF >/etc/systemd/system/valhalla.service
+[Unit]
+Description=Valhalla Routing Engine
+After=network.target
+
+[Service]
+Type=simple
+User=valhalla
+Group=valhalla
+WorkingDirectory=/opt/valhalla_data
+ExecStart=/usr/local/bin/valhalla_service /opt/valhalla_data/valhalla.json ${THREADS}
+Restart=on-failure
+RestartSec=5
+
+[Install]
+WantedBy=multi-user.target
+EOF
+systemctl enable -q --now valhalla
+msg_ok "Created Service"
+
+if [[ -n "${VALHALLA_PBF_URLS:-}" ]]; then
+  msg_info "Building Initial Tiles from VALHALLA_PBF_URLS (this can take a long time)"
+  $STD /opt/valhalla_data/build-tiles.sh $VALHALLA_PBF_URLS
+  msg_ok "Built Initial Tiles"
+fi
+
+motd_ssh
+customize
+cleanup_lxc

tools/pve/monitor-all.sh

@@ -45,6 +45,8 @@ add() {
 excluded_instances=("$@")
 echo "Excluded instances: ${excluded_instances[@]}"
 
+value_of() { sed -n "s/^$1:[[:space:]]*//p" <<<"$config" | head -n1; }
+
 while true; do
 
   for instance in $(pct list | awk 'NR>1 {print $1}'; qm list | awk 'NR>1 {print $1}'); do
@@ -59,21 +61,21 @@ while true; do
     if [ -r "/etc/pve/lxc/$instance.conf" ]; then
       type="ct"
       config_file="/etc/pve/lxc/$instance.conf"
-    else
+    elif [ -r "/etc/pve/qemu-server/$instance.conf" ]; then
       type="vm"
       config_file="/etc/pve/qemu-server/$instance.conf"
+    else
+      echo "Skipping $instance because its config is no longer readable"
+      continue
     fi
     config=$(sed '/^\[/,$d' "$config_file")
 
-    # Skip templates and onboot-disabled
-    if grep -q "onboot: 0" <<<"$config" || ! grep -q "onboot" <<<"$config"; then
-      onboot="true"
-    else
-      onboot="false"
-    fi
-    template=$(grep -q "^template:" <<<"$config" && echo "true" || echo "false")
+    # Both are booleans that Proxmox also writes as 0, so the value decides and
+    # not the presence of the key.
+    [ "$(value_of onboot)" = "1" ] && onboot="true" || onboot="false"
+    [ "$(value_of template)" = "1" ] && template="true" || template="false"
 
-    if [ "$onboot" == "true" ]; then
+    if [ "$onboot" != "true" ]; then
       echo "Skipping $instance because it is set not to boot"
       continue
     elif [ "$template" == "true" ]; then
@@ -81,34 +83,40 @@ while true; do
       continue
     fi
 
-    # Check for mon-restart tag
-    has_tag=$(grep -q "tags:.*mon-restart" <<<"$config" && echo "true" || echo "false")
-    if [ "$has_tag" != "true" ]; then
+    # Tags are semicolon separated, so match a whole entry instead of a
+    # substring of a longer tag such as mon-restart-disabled.
+    tags=";$(value_of tags | tr -d '[:space:]');"
+    if [[ "$tags" != *";mon-restart;"* ]]; then
       echo "Skipping $instance because it does not have 'mon-restart' tag"
       continue
     fi
 
     # Responsiveness check and restart if needed
     if [ "$type" == "vm" ]; then
-      # Check if guest agent responds
-      if qm guest cmd $instance ping >/dev/null 2>&1; then
+      if ! qm status "$instance" 2>/dev/null | grep -q "status: running"; then
+        echo "$(date): VM $instance is not running, starting..."
+        qm start "$instance" >/dev/null 2>&1
+      elif qm guest cmd "$instance" ping >/dev/null 2>&1; then
         echo "VM $instance is responsive via guest agent"
       else
         echo "$(date): VM $instance is not responding to agent ping, restarting..."
-        if qm status $instance | grep -q "status: running"; then
-          qm stop $instance >/dev/null 2>&1
-          sleep 5
-        fi
-        qm start $instance >/dev/null 2>&1
+        qm stop "$instance" >/dev/null 2>&1
+        sleep 5
+        qm start "$instance" >/dev/null 2>&1
       fi
     else
-      # Container: get IP and ping
-      IP=$(pct exec $instance ip a s dev eth0 | awk '/inet / {print $2}' | cut -d/ -f1 | head -n1)
-      if ! ping -c 1 $IP >/dev/null 2>&1; then
+      if ! pct status "$instance" 2>/dev/null | grep -q "status: running"; then
+        echo "$(date): CT $instance is not running, starting..."
+        pct start "$instance" >/dev/null 2>&1
+        continue
+      fi
+      # Not every container names its interface eth0.
+      IP=$(pct exec "$instance" -- ip -4 -o addr show scope global 2>/dev/null | awk '{print $4}' | cut -d/ -f1 | head -n1)
+      if [ -z "$IP" ] || ! ping -c 1 -W 2 "$IP" >/dev/null 2>&1; then
         echo "$(date): CT $instance is not responding, restarting..."
-        pct stop $instance >/dev/null 2>&1
+        pct stop "$instance" >/dev/null 2>&1
         sleep 5
-        pct start $instance >/dev/null 2>&1
+        pct start "$instance" >/dev/null 2>&1
       else
         echo "CT $instance is responsive"
       fi
@@ -124,23 +132,18 @@ EOF
   touch /var/log/ping-instances.log
   chmod +x /usr/local/bin/ping-instances.sh
 
-  cat <<EOF >/etc/systemd/system/ping-instances.timer
-[Unit]
-Description=Delay ping-instances.service by 5 minutes
-
-[Timer]
-OnBootSec=300
-OnUnitActiveSec=300
-
-[Install]
-WantedBy=timers.target
-EOF
+  # The service loops with its own five minute sleep, so the timer that earlier
+  # versions installed could only ever start a unit that was already running.
+  if [[ -f /etc/systemd/system/ping-instances.timer ]]; then
+    systemctl disable -q --now ping-instances.timer 2>/dev/null || true
+    rm -f /etc/systemd/system/ping-instances.timer
+  fi
 
   cat <<EOF >/etc/systemd/system/ping-instances.service
 [Unit]
 Description=Ping instances every 5 minutes and restart if necessary
-After=ping-instances.timer
-Requires=ping-instances.timer
+After=pve-cluster.service
+Wants=pve-cluster.service
 
 [Service]
 Type=simple
@@ -158,7 +161,6 @@ WantedBy=multi-user.target
 EOF
 
   systemctl daemon-reload
-  systemctl enable -q --now ping-instances.timer
   systemctl enable -q --now ping-instances.service
   clear
   echo -e "\n Monitor All installed."
@@ -167,7 +169,7 @@ EOF
 }
 
 remove() {
-  systemctl disable -q --now ping-instances.timer
+  systemctl disable -q --now ping-instances.timer 2>/dev/null || true
   systemctl disable -q --now ping-instances.service
   rm -f /etc/systemd/system/ping-instances.service
   rm -f /etc/systemd/system/ping-instances.timer