Update CHANGELOG.md (#17558 )

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Serve linkding's favicons and preview images (#17557 )
2026-09-28 06:55:11 -04:00 · 2026-09-28 07:14:20 +00:00 · 2026-09-28 09:13:57 +02:00 · 2026-09-28 09:13:47 +02:00
5 changed files with 27 additions and 2 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -549,6 +549,15 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit

 </details>

+## 2026-09-28
+
+### 🚀 Updated Scripts
+
+  - #### 🐞 Bug Fixes
+
+    - linkding: serve favicons and preview images [@MickLesk](https://github.com/MickLesk) ([#17557](https://github.com/community-scripts/ProxmoxVE/pull/17557))
+    - SparkyFitness: Fill in the nginx resolver 1.7.3 added [@MickLesk](https://github.com/MickLesk) ([#17556](https://github.com/community-scripts/ProxmoxVE/pull/17556))
+
 ## 2026-09-27

 ### 🚀 Updated Scripts
--- a/ct/linkding.sh
+++ b/ct/linkding.sh
@@ -32,6 +32,16 @@ function update_script() {
    exit
  fi

+  if grep -q 'alias /opt/linkding/static/;' /etc/nginx/sites-available/linkding 2>/dev/null; then
+    msg_info "Serving Favicons and Preview Images"
+    sed -i \
+      -e 's|location /static/ {|location ~ ^/static/(.*)$ {|' \
+      -e 's|alias /opt/linkding/static/;|root /opt/linkding;\n        try_files /static/$1 /data/favicons/$1 /data/previews/$1 =404;\n        add_header Content-Security-Policy "sandbox";|' \
+      /etc/nginx/sites-available/linkding
+    $STD systemctl reload nginx
+    msg_ok "Serving Favicons and Preview Images"
+  fi
+
  if check_for_gh_release "linkding" "sissbruecker/linkding"; then
    msg_info "Stopping Services"
    systemctl stop nginx linkding linkding-tasks
--- a/ct/sparkyfitness.sh
+++ b/ct/sparkyfitness.sh
@@ -62,12 +62,14 @@ function update_script() {

    msg_info "Refreshing Nginx Config"
    FRONTEND_URL=$(grep -oP '^SPARKY_FITNESS_FRONTEND_URL=\K.*' /etc/sparkyfitness/.env)
+    NGINX_RESOLVER=$(awk '$1=="nameserver" {ns=$2; sub(/%.*/, "", ns); printf "%s%s", sep, (ns ~ /:/ ? "[" ns "]" : ns); sep=" "}' /etc/resolv.conf)
    sed \
      -e 's|${SPARKY_FITNESS_SERVER_HOST}|127.0.0.1|g' \
      -e 's|${SPARKY_FITNESS_SERVER_PORT}|3010|g' \
      -e "s|\${SPARKY_FITNESS_FRONTEND_URL}|${FRONTEND_URL}|g" \
      -e 's|${NGINX_LISTEN_PORT}|80|g' \
      -e 's|${NGINX_RATE_LIMIT}|5r/s|g' \
+      -e "s|\${NGINX_RESOLVER}|${NGINX_RESOLVER:-127.0.0.1}|g" \
      -e 's|${NGINX_ACCESS_LOG}|/var/log/nginx/sparkyfitness.access.log|g' \
      -e 's|${NGINX_ERROR_LOG}|/var/log/nginx/sparkyfitness.error.log|g' \
      -e 's|root /usr/share/nginx/html;|root /var/www/sparkyfitness;|g' \
--- a/install/linkding-install.sh
+++ b/install/linkding-install.sh
@@ -101,8 +101,10 @@ server {

    client_max_body_size 20M;

-    location /static/ {
-        alias /opt/linkding/static/;
+    location ~ ^/static/(.*)$ {
+        root /opt/linkding;
+        try_files /static/$1 /data/favicons/$1 /data/previews/$1 =404;
+        add_header Content-Security-Policy "sandbox";
        expires 30d;
    }

--- a/install/sparkyfitness-install.sh
+++ b/install/sparkyfitness-install.sh
@@ -81,12 +81,14 @@ systemctl enable -q --now sparkyfitness-server
 msg_ok "Created SparkyFitness Service"

 msg_info "Configuring Nginx"
+NGINX_RESOLVER=$(awk '$1=="nameserver" {ns=$2; sub(/%.*/, "", ns); printf "%s%s", sep, (ns ~ /:/ ? "[" ns "]" : ns); sep=" "}' /etc/resolv.conf)
 sed \
  -e 's|${SPARKY_FITNESS_SERVER_HOST}|127.0.0.1|g' \
  -e 's|${SPARKY_FITNESS_SERVER_PORT}|3010|g' \
  -e "s|\${SPARKY_FITNESS_FRONTEND_URL}|http://${LOCAL_IP}:80|g" \
  -e 's|${NGINX_LISTEN_PORT}|80|g' \
  -e 's|${NGINX_RATE_LIMIT}|5r/s|g' \
+  -e "s|\${NGINX_RESOLVER}|${NGINX_RESOLVER:-127.0.0.1}|g" \
  -e 's|${NGINX_ACCESS_LOG}|/var/log/nginx/sparkyfitness.access.log|g' \
  -e 's|${NGINX_ERROR_LOG}|/var/log/nginx/sparkyfitness.error.log|g' \
  -e 's|root /usr/share/nginx/html;|root /var/www/sparkyfitness;|g' \
Author	SHA1	Message	Date
community-scripts-pr-app[bot]	a50fe45184	Update CHANGELOG.md (#17558 ) Some checks are pending Auto Update .app-files / update-app-files (push) Waiting to run Details Create Changelog Pull Request / update-changelog-pull-request (push) Waiting to run Details Set state to is_deleted in pocketbase / delete-pocketbase-entry (push) Waiting to run Details Sync ct/install to Incus / dispatch (push) Waiting to run Details Update script timestamp on .sh changes / update-script-timestamp (push) Waiting to run Details Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2026-09-28 07:14:20 +00:00
CanbiZ (MickLesk)	9312a32495	Serve linkding's favicons and preview images (#17557 ) linkding stores them in data/favicons and data/previews and upstream maps both under /static next to the collected assets, with a sandbox CSP. The nginx site only aliased the collected assets, so every downloaded image answered 404; the update rewrites that block even without a new release.	2026-09-28 09:13:57 +02:00
CanbiZ (MickLesk)	2ee7d13367	Fill in the nginx resolver SparkyFitness 1.7.3 added (#17556 ) Upstream's nginx.conf gained a resolver ${NGINX_RESOLVER} line that its Docker entrypoint fills from /etc/resolv.conf; the script substitutes a fixed list of placeholders, so the literal variable reached nginx and the config test failed. Take the nameservers from resolv.conf the same way.	2026-09-28 09:13:47 +02:00