Update license URL in ubuntu-vm.sh

Updated licensing information and improved error handling. Refactored OS selection logic and cloud-init prompts.

CHANGELOG.md

@@ -561,31 +561,17 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 
 ## 2026-10-08
 
-### 🆕 New Scripts
-
-  - Unifi-OS-Server VM ([#17752](https://github.com/community-scripts/ProxmoxVE/pull/17752))
-- ZimaOS VM ([#17778](https://github.com/community-scripts/ProxmoxVE/pull/17778))
-
 ### 🚀 Updated Scripts
 
   - Revert "Immich: Pin to v3.3.0" [@MickLesk](https://github.com/MickLesk) ([#17767](https://github.com/community-scripts/ProxmoxVE/pull/17767))
 
-  - #### ✨ New Features
-
-    - Immich: Pin to 3.3.0 / Update ML Python to 3.13 [@MickLesk](https://github.com/MickLesk) ([#17770](https://github.com/community-scripts/ProxmoxVE/pull/17770))
-
-  - #### 🔧 Refactor
-
-    - Refactor: Ubuntu VM [@MickLesk](https://github.com/MickLesk) ([#17776](https://github.com/community-scripts/ProxmoxVE/pull/17776))
-
 ### 💾 Core
 
-  - Take the ISO storage from the disk pool when it can hold ISOs [@MickLesk](https://github.com/MickLesk) ([core#122](https://github.com/community-scripts/core/pull/122))
-- Shared VM helpers: disk import, releases, checksums, first boot, IP by MAC [@MickLesk](https://github.com/MickLesk) ([core#117](https://github.com/community-scripts/core/pull/117))
-- tools: forge truncated release list [@MickLesk](https://github.com/MickLesk) ([core#118](https://github.com/community-scripts/core/pull/118))
-- Remember a kept cached image until the upstream changes [@MickLesk](https://github.com/MickLesk) ([core#119](https://github.com/community-scripts/core/pull/119))
+  - VM's: run first-boot units without debconf dialogs [@MickLesk](https://github.com/MickLesk) ([core#121](https://github.com/community-scripts/core/pull/121))
 - Choose the VM keyboard layout and carry the host's timezone into prepared images [@MickLesk](https://github.com/MickLesk) ([core#120](https://github.com/community-scripts/core/pull/120))
-- VM's: run first-boot units without debconf dialogs [@MickLesk](https://github.com/MickLesk) ([core#121](https://github.com/community-scripts/core/pull/121))
+- Remember a kept cached image until the upstream changes [@MickLesk](https://github.com/MickLesk) ([core#119](https://github.com/community-scripts/core/pull/119))
+- tools: forge truncated release list [@MickLesk](https://github.com/MickLesk) ([core#118](https://github.com/community-scripts/core/pull/118))
+- Shared VM helpers: disk import, releases, checksums, first boot, IP by MAC [@MickLesk](https://github.com/MickLesk) ([core#117](https://github.com/community-scripts/core/pull/117))
 
 ## 2026-10-07
 

ct/bookorbit.sh

@@ -48,12 +48,7 @@ function update_script() {
 
     $STD corepack prepare "pnpm@${PNPM_VERSION}" --activate
     $STD pnpm install --frozen-lockfile
-    # vite's bundler (rolldown) crashes at random on some builds, rolldown#10860.
-    for attempt in 1 2 3; do
-      $STD pnpm --filter client run build-only && break
-      [[ $attempt -eq 3 ]] && { msg_error "Client build failed three times"; exit 1; }
-      msg_warn "Client build failed (attempt $attempt), retrying"
-    done
+    $STD pnpm --filter client run build-only
     $STD pnpm --filter server run build
     cp -r /opt/bookorbit/client/dist /opt/bookorbit/server/public
     mkdir -p /opt/bookorbit/server/migrations

ct/immich.sh

@@ -77,7 +77,7 @@ EOF
   BASE_DIR=${STAGING_DIR}/base-images
   SOURCE_DIR=${STAGING_DIR}/image-source
   cd /tmp
-  RELEASE="v3.3.0"
+  RELEASE="v3.2.4"
   if [[ -f ~/.intel_version ]]; then
     INTEL_SRC="https://raw.githubusercontent.com/immich-app/immich/${RELEASE}/machine-learning"
     curl -fsSL "${INTEL_SRC}/scripts/install-intel-runtime.sh" -o ./intel-runtime 2>/dev/null ||
@@ -274,13 +274,12 @@ EOF
       msg_info "Updating Intel OpenVINO machine-learning"
       for attempt in $(seq 1 3); do
         $STD sudo --preserve-env=VIRTUAL_ENV,UV_HTTP_TIMEOUT -Pnu immich uv sync --extra openvino --no-dev --active --link-mode copy -n -p "${ML_PYTHON}" --managed-python && break
-        [[ $attempt -eq 3 ]] && { msg_error "uv sync failed three times, the machine-learning environment was not built"; exit 1; }
-        msg_warn "uv sync attempt $attempt failed, retrying..." && sleep 10
+        [[ $attempt -lt 3 ]] && msg_warn "uv sync attempt $attempt failed, retrying..." && sleep 10
       done
       patchelf --clear-execstack "${VIRTUAL_ENV}/lib/python3.13/site-packages/onnxruntime/capi/onnxruntime_pybind11_state.cpython-313-$(arch_resolve "x86_64" "aarch64")-linux-gnu.so"
       msg_ok "Updated Intel OpenVINO machine-learning"
     else
-      ML_PYTHON="python3.13"
+      ML_PYTHON="python3.11"
       msg_info "Pre-installing Python ${ML_PYTHON} for machine-learning"
       for attempt in $(seq 1 3); do
         $STD sudo --preserve-env=VIRTUAL_ENV -Pnu immich uv python install "${ML_PYTHON}" && break
@@ -290,8 +289,7 @@ EOF
       msg_info "Updating machine-learning"
       for attempt in $(seq 1 3); do
         $STD sudo --preserve-env=VIRTUAL_ENV,UV_HTTP_TIMEOUT -Pnu immich uv sync --extra cpu --no-dev --active --link-mode copy -n -p "${ML_PYTHON}" --managed-python && break
-        [[ $attempt -eq 3 ]] && { msg_error "uv sync failed three times, the machine-learning environment was not built"; exit 1; }
-        msg_warn "uv sync attempt $attempt failed, retrying..." && sleep 10
+        [[ $attempt -lt 3 ]] && msg_warn "uv sync attempt $attempt failed, retrying..." && sleep 10
       done
       msg_ok "Updated machine-learning"
     fi
@@ -335,10 +333,6 @@ EOF
       sed -i -e '$a\' "$INSTALL_DIR"/.env
       echo "IMMICH_HELMET_FILE=true" >>"$INSTALL_DIR"/.env
     fi
-    if ! grep -q 'MODEL_REVISION' "$INSTALL_DIR"/.env; then
-      sed -i -e '$a\' "$INSTALL_DIR"/.env
-      echo "MACHINE_LEARNING_MODEL_REVISION=v2" >>"$INSTALL_DIR"/.env
-    fi
 
     if grep -q 'ExecStart=/usr/bin/node' /etc/systemd/system/immich-web.service; then
       sed -i '/^EnvironmentFile=/d' /etc/systemd/system/immich-web.service
@@ -347,12 +341,25 @@ EOF
     fi
 
     # MickLesk temporary patch for HEIC thumbnail gen
+    msg_info "Patching media.repository.js"
     MEDIA_REPO_JS="/opt/immich/app/dist/repositories/media.repository.js"
-    if grep -qF "(0, sharp_1.default)(input).metadata()" "$MEDIA_REPO_JS" 2>/dev/null; then
-      msg_info "Patching media.repository.js"
-      sed -i '0,/(0, sharp_1\.default)(input)\.metadata()/s//(0, sharp_1.default)(input, { unlimited: true, limitInputPixels: false }).metadata()/' "$MEDIA_REPO_JS"
-      msg_ok "Patched media.repository.js"
+    if [[ -f "$MEDIA_REPO_JS" ]]; then
+      python3 - <<'PY'
+from pathlib import Path
+p = Path('/opt/immich/app/dist/repositories/media.repository.js')
+s = p.read_text()
+old = "(0, sharp_1.default)(input).metadata()"
+new = "(0, sharp_1.default)(input, { unlimited: true, limitInputPixels: false }).metadata()"
+if new in s:
+    print('hotfix already there')
+elif old in s:
+    p.write_text(s.replace(old, new, 1))
+    print('hotfix applied')
+else:
+    print('pattern not found, skipped')
+PY
     fi
+    msg_ok "Patched media.repository.js"
 
     # chown excluding upload dir contents (may be a mount with restricted permissions)
     chown immich:immich "$INSTALL_DIR"

install/bookorbit-install.sh

@@ -33,12 +33,7 @@ PNPM_VERSION=$(jq -r '.packageManager | ltrimstr("pnpm@")' /opt/bookorbit/packag
 
 $STD corepack prepare "pnpm@${PNPM_VERSION}" --activate
 $STD pnpm install --frozen-lockfile
-# vite's bundler (rolldown) crashes at random on some builds, rolldown#10860.
-for attempt in 1 2 3; do
-  $STD pnpm --filter client run build-only && break
-  [[ $attempt -eq 3 ]] && { msg_error "Client build failed three times"; exit 1; }
-  msg_warn "Client build failed (attempt $attempt), retrying"
-done
+$STD pnpm --filter client run build-only
 $STD pnpm --filter server run build
 cp -r /opt/bookorbit/client/dist /opt/bookorbit/server/public
 mkdir -p /opt/bookorbit/server/migrations

install/immich-install.sh

@@ -13,7 +13,7 @@ setting_up_container
 network_check
 update_os
 
-RELEASE="v3.3.0"
+RELEASE="v3.2.4"
 if lscpu | grep -q 'GenuineIntel'; then
   echo ""
   echo ""
@@ -442,13 +442,12 @@ if [[ -f ~/.openvino ]]; then
   msg_info "Installing Intel OpenVINO machine-learning"
   for attempt in $(seq 1 3); do
     $STD sudo --preserve-env=VIRTUAL_ENV,UV_HTTP_TIMEOUT -Pnu immich uv sync --extra openvino --no-dev --active --link-mode copy -n -p "${ML_PYTHON}" --managed-python && break
-    [[ $attempt -eq 3 ]] && { msg_error "uv sync failed three times, the machine-learning environment was not built"; exit 1; }
-    msg_warn "uv sync attempt $attempt failed, retrying..." && sleep 10
+    [[ $attempt -lt 3 ]] && msg_warn "uv sync attempt $attempt failed, retrying..." && sleep 10
   done
   patchelf --clear-execstack "${VIRTUAL_ENV}/lib/python3.13/site-packages/onnxruntime/capi/onnxruntime_pybind11_state.cpython-313-$(arch_resolve "x86_64" "aarch64")-linux-gnu.so"
   msg_ok "Installed Intel OpenVINO machine-learning"
 else
-  ML_PYTHON="python3.13"
+  ML_PYTHON="python3.11"
   msg_info "Pre-installing Python ${ML_PYTHON} for machine-learning"
   for attempt in $(seq 1 3); do
     $STD sudo --preserve-env=VIRTUAL_ENV -Pnu immich uv python install "${ML_PYTHON}" && break
@@ -458,8 +457,7 @@ else
   msg_info "Installing machine-learning"
   for attempt in $(seq 1 3); do
     $STD sudo --preserve-env=VIRTUAL_ENV,UV_HTTP_TIMEOUT -Pnu immich uv sync --extra cpu --no-dev --active --link-mode copy -n -p "${ML_PYTHON}" --managed-python && break
-    [[ $attempt -eq 3 ]] && { msg_error "uv sync failed three times, the machine-learning environment was not built"; exit 1; }
-    msg_warn "uv sync attempt $attempt failed, retrying..." && sleep 10
+    [[ $attempt -lt 3 ]] && msg_warn "uv sync attempt $attempt failed, retrying..." && sleep 10
   done
   msg_ok "Installed machine-learning"
 fi
@@ -490,12 +488,25 @@ ln -s "$GEO_DIR" "$APP_DIR"
 msg_ok "Installed GeoNames data"
 
 # MickLesk temporary patch for HEIC thumbnail gen
+msg_info "Patching media.repository.js"
 MEDIA_REPO_JS="/opt/immich/app/dist/repositories/media.repository.js"
-if grep -qF "(0, sharp_1.default)(input).metadata()" "$MEDIA_REPO_JS" 2>/dev/null; then
-  msg_info "Patching media.repository.js"
-  sed -i '0,/(0, sharp_1\.default)(input)\.metadata()/s//(0, sharp_1.default)(input, { unlimited: true, limitInputPixels: false }).metadata()/' "$MEDIA_REPO_JS"
-  msg_ok "Patched media.repository.js"
+if [[ -f "$MEDIA_REPO_JS" ]]; then
+  python3 - <<'PY'
+from pathlib import Path
+p = Path('/opt/immich/app/dist/repositories/media.repository.js')
+s = p.read_text()
+old = "(0, sharp_1.default)(input).metadata()"
+new = "(0, sharp_1.default)(input, { unlimited: true, limitInputPixels: false }).metadata()"
+if new in s:
+    print('hotfix already there')
+elif old in s:
+    p.write_text(s.replace(old, new, 1))
+    print('hotfix applied')
+else:
+    print('pattern not found, skipped')
+PY
 fi
+msg_ok "Patched media.repository.js"
 
 mkdir -p /var/log/immich
 touch /var/log/immich/{web.log,ml.log}
@@ -526,7 +537,6 @@ MACHINE_LEARNING_CACHE_FOLDER=${INSTALL_DIR}/cache
 ## - inference speed while reducing accuracy
 ## - Default is FP32
 # MACHINE_LEARNING_OPENVINO_PRECISION=FP16
-MACHINE_LEARNING_MODEL_REVISION=v2
 
 IMMICH_MEDIA_LOCATION=${UPLOAD_DIR}
 EOF

vm/nextcloud-vm.sh

@@ -1,42 +1,218 @@
-#!/usr/bin/env bash
+#!/usr/bin/env bash
+
 # Copyright (c) 2021-2026 tteck
-# Author: tteck (tteckster) | MickLesk (CanbiZ)
+# Author: tteck (tteckster)
 # License: MIT
 # https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 
-COMMUNITY_SCRIPTS_URL="${COMMUNITY_SCRIPTS_URL:-https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main}"
-source <(curl -fsSL "${COMMUNITY_SCRIPTS_CORE_URL:-https://raw.githubusercontent.com/community-scripts/core/main}/pve/vm-core.func")
-load_functions
+source /dev/stdin <<<$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/api.func)
 
+function header_info {
+  clear
+  cat <<"EOF"
+ ______              __ __           _  __        __      __             __  _   ____  ___
+/_  __/_ _________  / //_/__ __ __  / |/ /____ __/ /_____/ /__  __ _____/ / | | / /  |/  /
+ / / / // / __/ _ \/ ,< / -_) // / /    / -_) \ / __/ __/ / _ \/ // / _  /  | |/ / /|_/ / 
+/_/  \_,_/_/ /_//_/_/|_|\__/\_, / /_/|_/\__/_\_\\__/\__/_/\___/\_,_/\_,_/   |___/_/  /_/  
+                           /___/
+EOF
+}
+header_info
+echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
-APP="Nextcloud"
-APP_TYPE="vm"
 NSAPP="nextcloud-vm"
 var_os="turnkey-nextcloud"
-var_version="19.0"
+var_version="n.d."
+
+YW=$(echo "\033[33m")
+BL=$(echo "\033[36m")
+RD=$(echo "\033[01;31m")
+BGN=$(echo "\033[4;92m")
+GN=$(echo "\033[1;92m")
+DGN=$(echo "\033[32m")
+CL=$(echo "\033[m")
+
+CL=$(echo "\033[m")
+BOLD=$(echo "\033[1m")
+BFR="\\r\\033[K"
+HOLD=" "
+TAB="  "
+
+CM="${TAB}✔️${TAB}${CL}"
+CROSS="${TAB}✖️${TAB}${CL}"
+INFO="${TAB}💡${TAB}${CL}"
+OS="${TAB}🖥️${TAB}${CL}"
+CONTAINERTYPE="${TAB}📦${TAB}${CL}"
+DISKSIZE="${TAB}💾${TAB}${CL}"
+CPUCORE="${TAB}🧠${TAB}${CL}"
+RAMSIZE="${TAB}🛠️${TAB}${CL}"
+CONTAINERID="${TAB}🆔${TAB}${CL}"
+HOSTNAME="${TAB}🏠${TAB}${CL}"
+BRIDGE="${TAB}🌉${TAB}${CL}"
+GATEWAY="${TAB}🌐${TAB}${CL}"
+DEFAULT="${TAB}⚙️${TAB}${CL}"
+MACADDRESS="${TAB}🔗${TAB}${CL}"
+VLANTAG="${TAB}🏷️${TAB}${CL}"
+CREATING="${TAB}🚀${TAB}${CL}"
+ADVANCED="${TAB}🧩${TAB}${CL}"
+CLOUD="${TAB}☁️${TAB}${CL}"
 
 THIN="discard=on,ssd=1,"
-
-header_info
-echo -e "\n Loading..."
-set -Eeo pipefail
-shopt -s inherit_errexit
+set -e
 trap 'error_handler $LINENO "$BASH_COMMAND"' ERR
 trap cleanup EXIT
 trap 'post_update_to_api "failed" "130"' SIGINT
 trap 'post_update_to_api "failed" "143"' SIGTERM
 trap 'post_update_to_api "failed" "129"; exit 129' SIGHUP
+function error_handler() {
+  local exit_code="$?"
+  local line_number="$1"
+  local command="$2"
+  local error_message="${RD}[ERROR]${CL} in line ${RD}$line_number${CL}: exit code ${RD}$exit_code${CL}: while executing command ${YW}$command${CL}"
+  post_update_to_api "failed" "${exit_code}"
+  echo -e "\n$error_message\n"
+  cleanup_vmid
+}
 
-vm_require_arch amd64
+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
+function cleanup_vmid() {
+  if qm status $VMID &>/dev/null; then
+    qm stop $VMID &>/dev/null
+    qm destroy $VMID &>/dev/null
+  fi
+}
+
+function cleanup() {
+  local exit_code=$?
+  popd >/dev/null
+  if [[ "${POST_TO_API_DONE:-}" == "true" && "${POST_UPDATE_DONE:-}" != "true" ]]; then
+    if [[ $exit_code -eq 0 ]]; then
+      post_update_to_api "done" "none"
+    else
+      post_update_to_api "failed" "$exit_code"
+    fi
+  fi
+  rm -rf $TEMP_DIR
+}
 
 TEMP_DIR=$(mktemp -d)
-pushd "$TEMP_DIR" >/dev/null
+pushd $TEMP_DIR >/dev/null
+if whiptail --backtitle "Proxmox VE Helper Scripts" --title "Nextcloud VM" --yesno "This will create a New Nextcloud VM. Proceed?" 10 58; then
+  :
+else
+  header_info && echo -e "${CROSS}${RD}User exited script${CL}\n" && exit
+fi
+
+function msg_info() {
+  local msg="$1"
+  echo -ne "${TAB}${YW}${HOLD}${msg}${HOLD}"
+}
+
+function msg_ok() {
+  local msg="$1"
+  echo -e "${BFR}${CM}${GN}${msg}${CL}"
+}
+
+function msg_error() {
+  local msg="$1"
+  echo -e "${BFR}${CROSS}${RD}${msg}${CL}"
+}
+
+function check_root() {
+  if [[ "$(id -u)" -ne 0 || $(ps -o comm= -p $PPID) == "sudo" ]]; then
+    clear
+    msg_error "Please run this script as root."
+    echo -e "\nExiting..."
+    sleep 2
+    exit
+  fi
+}
+
+# This function checks the version of Proxmox Virtual Environment (PVE) and exits if the version is not supported.
+# Supported: Proxmox VE 8.0.x – 8.9.x, 9.0 and 9.2
+pve_check() {
+  local PVE_VER
+  PVE_VER="$(pveversion | awk -F'/' '{print $2}' | awk -F'-' '{print $1}')"
+
+  # Check for Proxmox VE 8.x: allow 8.0–8.9
+  if [[ "$PVE_VER" =~ ^8\.([0-9]+) ]]; then
+    local MINOR="${BASH_REMATCH[1]}"
+    if ((MINOR < 0 || MINOR > 9)); then
+      msg_error "This version of Proxmox VE is not supported."
+      msg_error "Supported: Proxmox VE version 8.0 – 8.9"
+      exit 105
+    fi
+    return 0
+  fi
+
+  # Check for Proxmox VE 9.x: allow 9.0 and 9.2
+  if [[ "$PVE_VER" =~ ^9\.([0-9]+) ]]; then
+    local MINOR="${BASH_REMATCH[1]}"
+    if ((MINOR < 0 || MINOR > 2)); then
+      msg_error "This version of Proxmox VE is not supported."
+      msg_error "Supported: Proxmox VE version 9.0 – 9.2"
+      exit 105
+    fi
+    return 0
+  fi
+
+  # All other unsupported versions
+  msg_error "This version of Proxmox VE is not supported."
+  msg_error "Supported versions: Proxmox VE 8.0 – 8.x or 9.0 – 9.2"
+  exit 105
+}
+
+function arch_check() {
+  if [ "$(dpkg --print-architecture)" != "amd64" ]; then
+    echo -e "\n ${INFO}${YWB}This script will not work with PiMox! \n"
+    echo -e "\n ${YWB}Visit https://github.com/asylumexp/Proxmox for ARM64 support. \n"
+    echo -e "Exiting..."
+    sleep 2
+    exit
+  fi
+}
+
+function ssh_check() {
+  if command -v pveversion >/dev/null 2>&1; then
+    if [ -n "${SSH_CLIENT:+x}" ]; then
+      if whiptail --backtitle "Proxmox VE Helper Scripts" --defaultno --title "SSH DETECTED" --yesno "It's suggested to use the Proxmox shell instead of SSH, since SSH can create issues while gathering variables. Would you like to proceed with using SSH?" 10 62; then
+        echo "you've been warned"
+      else
+        clear
+        exit
+      fi
+    fi
+  fi
+}
+
+function exit-script() {
+  clear
+  echo -e "\n${CROSS}${RD}User exited script${CL}\n"
+  exit
+}
 
 function default_settings() {
-  vm_apply_machine_type "i440fx"
   VMID=$(get_valid_nextid)
+  FORMAT=",efitype=4m"
+  MACHINE=""
   DISK_SIZE="10G"
   DISK_CACHE=""
   HN="nextcloud-vm"
@@ -49,28 +225,221 @@ function default_settings() {
   MTU=""
   START_VM="yes"
   METHOD="default"
-  vm_echo_default_settings
+  echo -e "${CONTAINERID}${BOLD}${DGN}Virtual Machine ID: ${BGN}${VMID}${CL}"
+  echo -e "${CONTAINERTYPE}${BOLD}${DGN}Machine Type: ${BGN}i440fx${CL}"
+  echo -e "${DISKSIZE}${BOLD}${DGN}Disk Size: ${BGN}${DISK_SIZE}${CL}"
+  echo -e "${DISKSIZE}${BOLD}${DGN}Disk Cache: ${BGN}None${CL}"
+  echo -e "${HOSTNAME}${BOLD}${DGN}Hostname: ${BGN}${HN}${CL}"
+  echo -e "${OS}${BOLD}${DGN}CPU Model: ${BGN}KVM64${CL}"
+  echo -e "${CPUCORE}${BOLD}${DGN}CPU Cores: ${BGN}${CORE_COUNT}${CL}"
+  echo -e "${RAMSIZE}${BOLD}${DGN}RAM Size: ${BGN}${RAM_SIZE}${CL}"
+  echo -e "${BRIDGE}${BOLD}${DGN}Bridge: ${BGN}${BRG}${CL}"
+  echo -e "${MACADDRESS}${BOLD}${DGN}MAC Address: ${BGN}${MAC}${CL}"
+  echo -e "${VLANTAG}${BOLD}${DGN}VLAN: ${BGN}Default${CL}"
+  echo -e "${DEFAULT}${BOLD}${DGN}Interface MTU Size: ${BGN}Default${CL}"
+  echo -e "${GATEWAY}${BOLD}${DGN}Start VM when completed: ${BGN}yes${CL}"
+  echo -e "${CREATING}${BOLD}${DGN}Creating a Nextcloud VM using the above default settings${CL}"
 }
 
 function advanced_settings() {
   METHOD="advanced"
-  vm_prompt_vmid "${VMID:-$(get_valid_nextid)}"
-  vm_prompt_machine_type "i440fx"
-  vm_prompt_disk_size "10G"
-  vm_prompt_disk_cache "none"
-  vm_prompt_hostname "nextcloud-vm"
-  vm_prompt_cpu_model "kvm64"
-  vm_prompt_cpu_cores "2"
-  vm_prompt_ram "2048"
-  vm_prompt_bridge "vmbr0"
-  vm_prompt_mac "$GEN_MAC"
-  vm_prompt_vlan
-  vm_prompt_mtu
-  vm_prompt_keyboard
-  vm_prompt_verbose "no"
-  vm_prompt_start_vm "yes"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
+  while true; do
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+      if [ -z "$VMID" ]; then
+        VMID=$(get_valid_nextid)
+      fi
+      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
+        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
+        sleep 2
+        continue
+      fi
+      echo -e "${CONTAINERID}${BOLD}${DGN}Virtual Machine ID: ${BGN}$VMID${CL}"
+      break
+    else
+      exit-script
+    fi
+  done
 
-  if vm_confirm_advanced_settings "Ready to create a Nextcloud VM?"; then
+  if MACH=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "MACHINE TYPE" --radiolist --cancel-button Exit-Script "Choose Type" 10 58 2 \
+    "i440fx" "Machine i440fx" ON \
+    "q35" "Machine q35" OFF \
+    3>&1 1>&2 2>&3); then
+    if [ $MACH = q35 ]; then
+      echo -e "${CONTAINERTYPE}${BOLD}${DGN}Machine Type: ${BGN}$MACH${CL}"
+      FORMAT=""
+      MACHINE=" -machine q35"
+    else
+      echo -e "${CONTAINERTYPE}${BOLD}${DGN}Machine Type: ${BGN}$MACH${CL}"
+      FORMAT=",efitype=4m"
+      MACHINE=""
+    fi
+  else
+    exit-script
+  fi
+
+  if DISK_SIZE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Disk Size in GiB (e.g., 10, 20)" 8 58 "$DISK_SIZE" --title "DISK SIZE" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    DISK_SIZE=$(echo "$DISK_SIZE" | tr -d ' ')
+    if [[ "$DISK_SIZE" =~ ^[0-9]+$ ]]; then
+      DISK_SIZE="${DISK_SIZE}G"
+      echo -e "${DISKSIZE}${BOLD}${DGN}Disk Size: ${BGN}$DISK_SIZE${CL}"
+    elif [[ "$DISK_SIZE" =~ ^[0-9]+G$ ]]; then
+      echo -e "${DISKSIZE}${BOLD}${DGN}Disk Size: ${BGN}$DISK_SIZE${CL}"
+    else
+      echo -e "${DISKSIZE}${BOLD}${RD}Invalid Disk Size. Please use a number (e.g., 10 or 10G).${CL}"
+      exit-script
+    fi
+  else
+    exit-script
+  fi
+
+  if DISK_CACHE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "DISK CACHE" --radiolist "Choose" --cancel-button Exit-Script 10 58 2 \
+    "0" "None (Default)" ON \
+    "1" "Write Through" OFF \
+    3>&1 1>&2 2>&3); then
+    if [ $DISK_CACHE = "1" ]; then
+      echo -e "${DISKSIZE}${BOLD}${DGN}Disk Cache: ${BGN}Write Through${CL}"
+      DISK_CACHE="cache=writethrough,"
+    else
+      echo -e "${DISKSIZE}${BOLD}${DGN}Disk Cache: ${BGN}None${CL}"
+      DISK_CACHE=""
+    fi
+  else
+    exit-script
+  fi
+
+  if VM_NAME=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Hostname" 8 58 nextcloud-vm --title "HOSTNAME" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if [ -z $VM_NAME ]; then
+      HN="nextcloud-vm"
+      echo -e "${HOSTNAME}${BOLD}${DGN}Hostname: ${BGN}$HN${CL}"
+    else
+      HN=$(echo "${VM_NAME,,}" | tr -cs 'a-z0-9-' '-' | sed 's/^-//;s/-$//')
+      if [ "$HN" != "${VM_NAME,,}" ]; then
+        whiptail --backtitle "Proxmox VE Helper Scripts" --title "HOSTNAME ADJUSTED" --msgbox "Invalid characters detected. Hostname has been adjusted to:\n\n  $HN" 10 58
+      fi
+      echo -e "${HOSTNAME}${BOLD}${DGN}Hostname: ${BGN}$HN${CL}"
+    fi
+  else
+    exit-script
+  fi
+
+  if CPU_TYPE1=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "CPU MODEL" --radiolist "Choose" --cancel-button Exit-Script 10 58 2 \
+    "0" "KVM64 (Default)" ON \
+    "1" "Host" OFF \
+    3>&1 1>&2 2>&3); then
+    if [ $CPU_TYPE1 = "1" ]; then
+      echo -e "${OS}${BOLD}${DGN}CPU Model: ${BGN}Host${CL}"
+      CPU_TYPE=" -cpu host"
+    else
+      echo -e "${OS}${BOLD}${DGN}CPU Model: ${BGN}KVM64${CL}"
+      CPU_TYPE=""
+    fi
+  else
+    exit-script
+  fi
+
+  while true; do
+    if CORE_COUNT=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Allocate CPU Cores" 8 58 2 --title "CORE COUNT" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+      if [ -z "$CORE_COUNT" ]; then CORE_COUNT="2"; fi
+      if [[ "$CORE_COUNT" =~ ^[1-9][0-9]*$ ]]; then
+        echo -e "${CPUCORE}${BOLD}${DGN}CPU Cores: ${BGN}$CORE_COUNT${CL}"
+        break
+      fi
+      whiptail --backtitle "Proxmox VE Helper Scripts" --title "INVALID INPUT" --msgbox "CPU Cores must be a positive integer (e.g., 2)." 8 58
+    else
+      exit-script
+    fi
+  done
+
+  while true; do
+    if RAM_SIZE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Allocate RAM in MiB" 8 58 2048 --title "RAM" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+      if [ -z "$RAM_SIZE" ]; then RAM_SIZE="2048"; fi
+      if [[ "$RAM_SIZE" =~ ^[1-9][0-9]*$ ]]; then
+        echo -e "${RAMSIZE}${BOLD}${DGN}RAM Size: ${BGN}$RAM_SIZE${CL}"
+        break
+      fi
+      whiptail --backtitle "Proxmox VE Helper Scripts" --title "INVALID INPUT" --msgbox "RAM Size must be a positive integer in MiB (e.g., 2048)." 8 58
+    else
+      exit-script
+    fi
+  done
+
+  if BRG=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a Bridge" 8 58 vmbr0 --title "BRIDGE" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if [ -z $BRG ]; then
+      BRG="vmbr0"
+      echo -e "${BRIDGE}${BOLD}${DGN}Bridge: ${BGN}$BRG${CL}"
+    else
+      echo -e "${BRIDGE}${BOLD}${DGN}Bridge: ${BGN}$BRG${CL}"
+    fi
+  else
+    exit-script
+  fi
+
+  while true; do
+    if MAC1=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a MAC Address" 8 58 $GEN_MAC --title "MAC ADDRESS" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+      if [ -z "$MAC1" ]; then
+        MAC="$GEN_MAC"
+        echo -e "${MACADDRESS}${BOLD}${DGN}MAC Address: ${BGN}$MAC${CL}"
+        break
+      fi
+      if [[ "$MAC1" =~ ^([0-9A-Fa-f]{2}:){5}[0-9A-Fa-f]{2}$ ]]; then
+        MAC="$MAC1"
+        echo -e "${MACADDRESS}${BOLD}${DGN}MAC Address: ${BGN}$MAC1${CL}"
+        break
+      fi
+      whiptail --backtitle "Proxmox VE Helper Scripts" --title "INVALID INPUT" --msgbox "Invalid MAC address format. Use XX:XX:XX:XX:XX:XX (e.g., AA:BB:CC:DD:EE:FF)." 8 58
+    else
+      exit-script
+    fi
+  done
+
+  while true; do
+    if VLAN1=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set a Vlan(leave blank for default)" 8 58 --title "VLAN" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+      if [ -z "$VLAN1" ]; then
+        VLAN1="Default"
+        VLAN=""
+        echo -e "${VLANTAG}${BOLD}${DGN}VLAN: ${BGN}$VLAN1${CL}"
+        break
+      fi
+      if [[ "$VLAN1" =~ ^[0-9]+$ ]] && [ "$VLAN1" -ge 1 ] && [ "$VLAN1" -le 4094 ]; then
+        VLAN=",tag=$VLAN1"
+        echo -e "${VLANTAG}${BOLD}${DGN}VLAN: ${BGN}$VLAN1${CL}"
+        break
+      fi
+      whiptail --backtitle "Proxmox VE Helper Scripts" --title "INVALID INPUT" --msgbox "VLAN must be a number between 1 and 4094, or leave blank for default." 8 58
+    else
+      exit-script
+    fi
+  done
+
+  while true; do
+    if MTU1=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Interface MTU Size (leave blank for default)" 8 58 --title "MTU SIZE" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+      if [ -z "$MTU1" ]; then
+        MTU1="Default"
+        MTU=""
+        echo -e "${DEFAULT}${BOLD}${DGN}Interface MTU Size: ${BGN}$MTU1${CL}"
+        break
+      fi
+      if [[ "$MTU1" =~ ^[0-9]+$ ]] && [ "$MTU1" -ge 576 ] && [ "$MTU1" -le 65520 ]; then
+        MTU=",mtu=$MTU1"
+        echo -e "${DEFAULT}${BOLD}${DGN}Interface MTU Size: ${BGN}$MTU1${CL}"
+        break
+      fi
+      whiptail --backtitle "Proxmox VE Helper Scripts" --title "INVALID INPUT" --msgbox "MTU Size must be a number between 576 and 65520, or leave blank for default." 8 58
+    else
+      exit-script
+    fi
+  done
+
+  if (whiptail --backtitle "Proxmox VE Helper Scripts" --title "START VIRTUAL MACHINE" --yesno "Start VM when completed?" 10 58); then
+    echo -e "${GATEWAY}${BOLD}${DGN}Start VM when completed: ${BGN}yes${CL}"
+    START_VM="yes"
+  else
+    echo -e "${GATEWAY}${BOLD}${DGN}Start VM when completed: ${BGN}no${CL}"
+    START_VM="no"
+  fi
+
+  if (whiptail --backtitle "Proxmox VE Helper Scripts" --title "ADVANCED SETTINGS COMPLETE" --yesno "Ready to create a Nextcloud VM?" --no-button Do-Over 10 58); then
     echo -e "${CREATING}${BOLD}${DGN}Creating a Nextcloud VM using the above advanced settings${CL}"
   else
     header_info
@@ -79,35 +448,145 @@ function advanced_settings() {
   fi
 }
 
-vm_preflight
-vm_start_script "Use Default Settings?\n\nDefaults:\n• 2 CPU Cores\n• 2 GB RAM\n• 10 GB Disk" 13 58
+function start_script() {
+  if (whiptail --backtitle "Proxmox VE Helper Scripts" --title "SETTINGS" --yesno "Use Default Settings?" --no-button Advanced 10 58); then
+    header_info
+    echo -e "${BL}Using Default Settings${CL}"
+    default_settings
+  else
+    header_info
+    echo -e "${RD}Using Advanced Settings${CL}"
+    advanced_settings
+  fi
+}
+
+check_root
+arch_check
+pve_check
+ssh_check
+start_script
 
 post_to_api_vm
 
-vm_select_storage "$HN"
-msg_info "Retrieving the ${APP} installer ISO"
-URL=https://mirror.turnkeylinux.org/turnkeylinux/images/iso/turnkey-nextcloud-19.0-trixie-amd64.iso
+msg_info "Validating Storage"
+while read -r line; do
+  TAG=$(echo $line | awk '{print $1}')
+  TYPE=$(echo $line | awk '{printf "%-10s", $2}')
+  FREE=$(echo $line | numfmt --field 4-6 --from-unit=K --to=iec --format %.2f | awk '{printf( "%9sB", $6)}')
+  ITEM="  Type: $TYPE Free: $FREE "
+  OFFSET=2
+  if [[ $((${#ITEM} + $OFFSET)) -gt ${MSG_MAX_LENGTH:-} ]]; then
+    MSG_MAX_LENGTH=$((${#ITEM} + $OFFSET))
+  fi
+  STORAGE_MENU+=("$TAG" "$ITEM" "OFF")
+done < <(pvesm status -content images | awk 'NR>1')
+VALID=$(pvesm status -content images | awk 'NR>1')
+if [ -z "$VALID" ]; then
+  msg_error "Unable to detect a valid storage location."
+  exit
+elif [ $((${#STORAGE_MENU[@]} / 3)) -eq 1 ]; then
+  STORAGE=${STORAGE_MENU[0]}
+else
+  while [ -z "${STORAGE:+x}" ]; do
+    STORAGE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "Storage Pools" --radiolist \
+      "Which storage pool would you like to use for ${HN}?\nTo make a selection, use the Spacebar.\n" \
+      16 $(($MSG_MAX_LENGTH + 23)) 6 \
+      "${STORAGE_MENU[@]}" 3>&1 1>&2 2>&3)
+  done
+fi
+msg_ok "Using ${CL}${BL}$STORAGE${CL} ${GN}for Storage Location."
+msg_ok "Virtual Machine ID is ${CL}${BL}$VMID${CL}."
+msg_info "Retrieving the URL for the $NAME Disk Image"
+URL=http://mirror.turnkeylinux.org/turnkeylinux/images/iso/turnkey-nextcloud-18.1-bookworm-amd64.iso
 sleep 2
 msg_ok "${CL}${BL}${URL}${CL}"
-vm_select_iso_storage "$(basename "$URL")" "$HN"
-vm_fetch_image "$URL" "$ISO_PATH" --cache --min-bytes $((100 * 1024 * 1024)) || exit 115
+curl -f#SL -o "$(basename "$URL")" "$URL"
+echo -en "\e[1A\e[0K"
+FILE=$(basename $URL)
+msg_ok "Downloaded ${CL}${BL}${FILE}${CL}"
 
-vm_claim_vmid
-msg_info "Creating a ${APP}"
-qm create $VMID -agent 1${MACHINE} -tablet 0 -bios seabios${CPU_TYPE} -cores $CORE_COUNT -memory $RAM_SIZE \
-  -name $HN -tags community-script -net0 virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU -onboot 1 -ostype l26 -scsihw virtio-scsi-pci \
-  -scsi0 "${STORAGE}:${DISK_SIZE%G},${DISK_CACHE}${THIN%,}" \
-  -cdrom "$ISO_VOLUME" -boot order='scsi0;ide2' >/dev/null
-vm_mark_created
-set_description
+STORAGE_TYPE=$(pvesm status -storage $STORAGE | awk 'NR>1 {print $2}')
+case $STORAGE_TYPE in
+nfs | dir)
+  DISK_EXT=".raw"
+  DISK_REF="$VMID/"
+  DISK_IMPORT="-format raw"
+  THIN=""
+  ;;
+btrfs)
+  DISK_EXT=".raw"
+  DISK_REF="$VMID/"
+  DISK_IMPORT="-format raw"
+  FORMAT=",efitype=4m"
+  THIN=""
+  ;;
+*)
+  DISK_EXT=""
+  DISK_REF=""
+  DISK_IMPORT="-format raw"
+  ;;
+esac
+for i in {0,1,2}; do
+  disk="DISK$i"
+  eval DISK${i}=vm-${VMID}-disk-${i}${DISK_EXT:-}
+  eval DISK${i}_REF=${STORAGE}:${DISK_REF:-}${!disk}
+done
 
-msg_ok "Created a ${APP} ${CL}${BL}(${HN})"
-vm_start_vm "$APP"
-vm_print_summary "Version=TurnKey Nextcloud ${var_version}" "Installer=$(basename "$URL")" "Web UI=https://<VM-IP>/" "Webmin=https://<VM-IP>:12321/"
-vm_next_steps \
-  "Open the VM Console in Proxmox and complete the TurnKey installer." \
-  "Set the root, Nextcloud admin, and database credentials when prompted." \
-  "After installation, detach the ISO: qm set ${VMID} --ide2 none." \
-  "Start or reboot the VM, then open https://<VM-IP>/ for Nextcloud." \
-  "Manage the appliance through Webmin at https://<VM-IP>:12321/."
-vm_finish "VM created; complete the TurnKey Nextcloud installation in the Proxmox console."
+msg_info "Creating a $NAME"
+qm create $VMID -agent 1${MACHINE} -tablet 0 -localtime 1 -bios seabios${CPU_TYPE} -cores $CORE_COUNT -memory $RAM_SIZE \
+  -name $HN -tags community-script -net0 virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU -onboot 1 -ostype l26 -scsihw virtio-scsi-pci
+pvesm alloc $STORAGE $VMID $DISK0 4M 1>&/dev/null
+pvesm alloc $STORAGE $VMID $DISK1 12G 1>&/dev/null
+qm importdisk $VMID ${FILE} $STORAGE ${DISK_IMPORT:-} 1>&/dev/null
+qm set $VMID \
+  -efidisk0 ${DISK0_REF}${FORMAT} \
+  -scsi0 ${DISK1_REF},${DISK_CACHE}${THIN} \
+  -scsi1 ${DISK2_REF},${DISK_CACHE}${THIN} \
+  -boot order='scsi1;scsi0' >/dev/null
+DESCRIPTION=$(
+  cat <<EOF
+<div align='center'>
+  <a href='https://community-scripts.org' target='_blank' rel='noopener noreferrer'>
+    <img src='https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/images/logo-81x112.png' alt='Logo' style='width:81px;height:112px;'/>
+  </a>
+
+  <h2 style='font-size: 24px; margin: 20px 0;'>Nextcloud VM</h2>
+
+  <p style='margin: 16px 0;'>
+    <a href='https://ko-fi.com/community_scripts' target='_blank' rel='noopener noreferrer'>
+      <img src='https://img.shields.io/badge/&#x2615;-Buy us a coffee-blue' alt='spend Coffee' />
+    </a>
+  </p>
+  
+  <span style='margin: 0 10px;'>
+    <i class="fa fa-github fa-fw" style="color: #f5f5f5;"></i>
+    <a href='https://github.com/community-scripts/ProxmoxVE' target='_blank' rel='noopener noreferrer' style='text-decoration: none; color: #00617f;'>GitHub</a>
+  </span>
+  <span style='margin: 0 10px;'>
+    <i class="fa fa-comments fa-fw" style="color: #f5f5f5;"></i>
+    <a href='https://github.com/community-scripts/ProxmoxVE/discussions' target='_blank' rel='noopener noreferrer' style='text-decoration: none; color: #00617f;'>Discussions</a>
+  </span>
+  <span style='margin: 0 10px;'>
+    <i class="fa fa-exclamation-circle fa-fw" style="color: #f5f5f5;"></i>
+    <a href='https://github.com/community-scripts/ProxmoxVE/issues' target='_blank' rel='noopener noreferrer' style='text-decoration: none; color: #00617f;'>Issues</a>
+  </span>
+</div>
+EOF
+)
+qm set $VMID -description "$DESCRIPTION" >/dev/null
+if [ -n "$DISK_SIZE" ]; then
+  msg_info "Resizing disk to $DISK_SIZE GB"
+  qm resize $VMID scsi0 ${DISK_SIZE} >/dev/null
+else
+  msg_info "Using default disk size of $DEFAULT_DISK_SIZE GB"
+  qm resize $VMID scsi0 ${DEFAULT_DISK_SIZE} >/dev/null
+fi
+
+msg_ok "Created a $NAME ${CL}${BL}(${HN})"
+if [ "$START_VM" == "yes" ]; then
+  msg_info "Starting $NAME"
+  qm start $VMID
+  msg_ok "Started $NAME"
+fi
+post_update_to_api "done" "none"
+msg_ok "Completed successfully!\n"

vm/unifi-os-server-vm.sh

@@ -1,436 +0,0 @@
-#!/usr/bin/env bash
-# Copyright (c) 2021-2026 community-scripts ORG
-# Author: MickLesk (CanbiZ)
-# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
-
-COMMUNITY_SCRIPTS_URL="${COMMUNITY_SCRIPTS_URL:-https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main}"
-source <(curl -fsSL "${COMMUNITY_SCRIPTS_CORE_URL:-https://raw.githubusercontent.com/community-scripts/core/main}/pve/vm-core.func")
-load_functions
-
-APP="UniFi OS Server"
-APP_TYPE="vm"
-NSAPP="unifi-os-server-vm"
-var_os="debian"
-var_version="13"
-GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
-METHOD=""
-CLOUDINIT_REQUIRED=1
-OS_TYPE=""
-OS_VERSION=""
-OS_CODENAME=""
-OS_DISPLAY=""
-THIN="discard=on,ssd=1,"
-
-header_info
-echo -e "\n Loading..."
-
-set -Eeuo pipefail
-shopt -s inherit_errexit
-trap 'error_handler $LINENO "$BASH_COMMAND"' ERR
-trap cleanup EXIT
-trap 'post_update_to_api "failed" "130"' SIGINT
-trap 'post_update_to_api "failed" "143"' SIGTERM
-trap 'post_update_to_api "failed" "129"; exit 129' SIGHUP
-
-vm_require_arch amd64
-
-TEMP_DIR=$(mktemp -d)
-pushd "$TEMP_DIR" >/dev/null
-
-vm_preflight
-vm_require_tools curl jq virt-customize
-
-function select_os() {
-  if [[ -n "${1:-}" ]]; then
-    OS_CHOICE="$1"
-  elif [[ "${VM_UNATTENDED:-0}" == "1" ]]; then
-    OS_CHOICE="${VM_OS_VERSION:-debian13}"
-  elif vm_dialog radiolist "SELECT OS" "Choose Operating System for UniFi OS VM" 12 68 2 \
-    "debian13" "Debian 13 (Trixie) - Latest" ON \
-    "ubuntu2404" "Ubuntu 24.04 LTS (Noble)" OFF; then
-    OS_CHOICE="$VM_DIALOG_RESULT"
-  else
-    exit_script
-  fi
-
-  case $OS_CHOICE in
-  debian13)
-    OS_TYPE="debian"
-    OS_VERSION="13"
-    OS_CODENAME="trixie"
-    OS_DISPLAY="Debian 13 (Trixie)"
-    var_os="debian"
-    var_version="13"
-    ;;
-  ubuntu2404)
-    OS_TYPE="ubuntu"
-    OS_VERSION="24.04"
-    OS_CODENAME="noble"
-    OS_DISPLAY="Ubuntu 24.04 LTS"
-    var_os="ubuntu"
-    var_version="24.04"
-    ;;
-  *)
-    msg_error "Unsupported OS '${OS_CHOICE}' (expected debian13 or ubuntu2404)"
-    exit 1
-    ;;
-  esac
-}
-
-function get_image_url() {
-  local arch
-  arch=$(vm_arch_resolve amd64 arm64)
-  case $OS_TYPE in
-  debian)
-    # Always use Cloud-Init variant for UniFi OS
-    echo "https://cloud.debian.org/images/cloud/${OS_CODENAME}/latest/debian-${OS_VERSION}-generic-${arch}.qcow2"
-    ;;
-  ubuntu)
-    # Ubuntu only has cloudimg variant (always with Cloud-Init support)
-    echo "https://cloud-images.ubuntu.com/${OS_CODENAME}/current/${OS_CODENAME}-server-cloudimg-${arch}.img"
-    ;;
-  esac
-}
-
-function default_settings() {
-  vm_apply_machine_type "q35"
-  select_os "${VM_OS_VERSION:-}"
-
-  # Set defaults for other settings
-  VMID=$(get_valid_nextid)
-  DISK_CACHE=""
-  DISK_SIZE="32G"
-  HN="unifi-server-os"
-  CPU_TYPE=" -cpu host"
-  CORE_COUNT="2"
-  RAM_SIZE="6144"
-  BRG="vmbr0"
-  MAC="$GEN_MAC"
-  VLAN=""
-  MTU=""
-  START_VM="yes"
-  METHOD="default"
-  vm_echo_default_settings
-}
-
-function advanced_settings() {
-  METHOD="advanced"
-  select_os
-  vm_prompt_vmid "${VMID:-$(get_valid_nextid)}"
-  vm_prompt_machine_type "q35"
-  vm_prompt_disk_size "32G"
-  vm_prompt_disk_cache "none"
-  vm_prompt_hostname "unifi-server-os"
-  vm_prompt_cpu_model "host"
-  vm_prompt_cpu_cores "2"
-  vm_prompt_ram "6144"
-  vm_prompt_bridge "vmbr0"
-  vm_prompt_mac "$GEN_MAC"
-  vm_prompt_vlan
-  vm_prompt_mtu
-  vm_prompt_keyboard
-  vm_prompt_verbose "no"
-  vm_prompt_start_vm "yes"
-
-  if vm_confirm_advanced_settings "Ready to create a UniFi OS Server VM?"; then
-    echo -e "${CREATING}${BOLD}${DGN}Creating a UniFi OS Server VM using the above advanced settings${CL}"
-  else
-    header_info
-    echo -e "${ADVANCED}${BOLD}${RD}Using Advanced Settings${CL}"
-    advanced_settings
-  fi
-}
-
-vm_start_script "Use Default Settings?\n\nDefaults:\n• 2 CPU Cores\n• 6 GB RAM\n• 32 GB Disk\n• Cloud-Init enabled" 14 58
-
-if [[ "${VM_UNATTENDED:-0}" == "1" ]]; then
-  CLOUDINIT_PASSWORD="${CLOUDINIT_PASSWORD:-${VM_ROOT_PASSWORD:-}}"
-fi
-vm_prompt_cloud_init "root"
-if [[ "${USE_CLOUD_INIT:-no}" != "yes" ]]; then
-  msg_error "UniFi OS Server requires Cloud-Init"
-  exit 1
-fi
-if ! declare -f setup_cloud_init >/dev/null; then
-  msg_error "Required Cloud-Init helpers are unavailable"
-  exit 1
-fi
-if [[ "${VM_UNATTENDED:-0}" == "1" && -n "${VM_SSH_KEYS:-}" && -z "${CLOUDINIT_SSH_KEYS:-}" ]]; then
-  if [[ -f "$VM_SSH_KEYS" ]]; then
-    cp "$VM_SSH_KEYS" "$TEMP_DIR/ssh-keys-input"
-  else
-    printf '%s\n' "$VM_SSH_KEYS" >"$TEMP_DIR/ssh-keys-input"
-  fi
-  CLOUDINIT_SSH_KEYS="$TEMP_DIR/ssh-keys.pub"
-  _ci_ssh_extract_keys_from_file "$TEMP_DIR/ssh-keys-input" >"$CLOUDINIT_SSH_KEYS"
-  if [[ ! -s "$CLOUDINIT_SSH_KEYS" ]] || ! ssh-keygen -lf "$CLOUDINIT_SSH_KEYS" >/dev/null; then
-    msg_error "VM_SSH_KEYS must contain valid SSH public keys or name a public-key file"
-    exit 1
-  fi
-fi
-
-post_to_api_vm
-
-msg_info "Checking system resources"
-SYSTEM_RAM_GB=$(grep MemTotal /proc/meminfo | awk '{printf "%.0f", $2 / 1024 / 1024}')
-SYSTEM_SWAP_GB=$(grep SwapTotal /proc/meminfo | awk '{printf "%.0f", $2 / 1024 / 1024}')
-SYSTEM_FREE_DISK_GB=$(df -BG / | awk 'NR==2 {print $4}' | sed 's/G//')
-if [[ ${SYSTEM_RAM_GB} -lt 4 ]]; then
-  msg_error "Warning: Less than 4GB RAM detected (${SYSTEM_RAM_GB}GB). Install may be slow."
-  sleep 3
-fi
-if [[ ${SYSTEM_FREE_DISK_GB} -lt 10 ]]; then
-  msg_error "Warning: Less than 10GB free disk detected. Install may fail."
-  sleep 3
-fi
-msg_ok "System resources: ${SYSTEM_RAM_GB}GB RAM, ${SYSTEM_FREE_DISK_GB}GB free disk"
-
-if command -v ufw &>/dev/null; then
-  if ufw status verbose | grep -q "Status: active"; then
-    msg_info "Setting up firewall rules for UniFi OS Server ports"
-    ufw allow 11443/tcp 2>/dev/null
-    ufw allow 8080/tcp 2>/dev/null
-    ufw allow 3478/tcp 2>/dev/null
-    ufw allow 3478/udp 2>/dev/null
-    msg_ok "Firewall rules configured"
-  fi
-fi
-
-vm_select_storage "$HN"
-
-# Fetch latest UniFi OS Server version and download URL
-msg_info "Fetching latest UniFi OS Server version"
-
-# Download firmware list from Ubiquiti API
-API_URL="https://fw-update.ui.com/api/firmware-latest"
-TEMP_JSON=$(mktemp)
-
-if ! curl -fsSL "$API_URL" -o "$TEMP_JSON"; then
-  rm -f "$TEMP_JSON"
-  msg_error "Failed to fetch data from Ubiquiti API"
-  exit 1
-fi
-
-# Parse JSON to find latest unifi-os-server linux-x64 version
-LATEST=$(jq -r '
-  ._embedded.firmware
-  | map(select(.product == "unifi-os-server"))
-  | map(select(.platform == "linux-x64"))
-  | sort_by(.version_major, .version_minor, .version_patch)
-  | last
-' "$TEMP_JSON")
-
-UOS_VERSION=$(echo "$LATEST" | jq -r '.version' | sed 's/^v//')
-UOS_URL=$(echo "$LATEST" | jq -r '._links.data.href')
-
-# Cleanup temp file
-rm -f "$TEMP_JSON"
-
-if [[ -z "$UOS_URL" || "$UOS_URL" == "null" || -z "$UOS_VERSION" || "$UOS_VERSION" == "null" ]]; then
-  msg_error "Failed to parse UniFi OS Server version or download URL"
-  exit 1
-fi
-
-UOS_INSTALLER="unifi-os-server-${UOS_VERSION}.bin"
-msg_ok "Found UniFi OS Server ${UOS_VERSION}"
-
-# --- Download Cloud Image ---
-msg_info "Downloading ${OS_DISPLAY} Cloud Image"
-URL=$(get_image_url)
-sleep 2
-msg_ok "${CL}${BL}${URL}${CL}"
-CACHE_FILE="$(vm_image_cache_path "$URL")"
-vm_fetch_image "$URL" "$CACHE_FILE" --cache --min-bytes $((100 * 1024 * 1024)) || exit 115
-FILE="$(basename "$CACHE_FILE")"
-# Work on a copy: image preparation rewrites the image, which would poison the cache for every later VM.
-cp -f "$CACHE_FILE" "$FILE"
-
-# Resize the imported disk with vm_resize_disk; Cloud-Init grows the actual root
-# filesystem before the first-boot installer runs, without another offline copy.
-
-# --- Download UniFi OS installer on the host ---
-msg_info "Downloading UniFi OS Server ${UOS_VERSION} installer"
-curl -fsSL "${UOS_URL}" -o "unifi-os-server.bin"
-chmod +x "unifi-os-server.bin"
-msg_ok "Downloaded UniFi OS Server installer"
-
-# --- Pre-install packages and setup first-boot installer ---
-msg_info "Customizing disk image (installing packages, staging installer)"
-
-# Create the first-boot installer script
-FIRSTBOOT_SCRIPT="$TEMP_DIR/unifi-os-firstboot.sh"
-cat >"$FIRSTBOOT_SCRIPT" <<'FBEOF'
-#!/usr/bin/env bash
-set -Eeuo pipefail
-LOG="/var/log/unifi-os-install.log"
-exec > >(tee -a "$LOG") 2>&1
-echo "[$(date)] Starting UniFi OS Server first-boot setup..."
-trap 'echo "[$(date)] ERROR: First-boot setup failed at line $LINENO"' ERR
-if ! systemctl start qemu-guest-agent; then
-  echo "[$(date)] WARNING: Preinstalled guest agent could not start; retrying after package installation"
-fi
-
-# Sync clock before apt (fresh VMs have clock skew that breaks GPG signature validation)
-echo "[$(date)] Syncing system clock..."
-if ! timedatectl set-ntp true; then
-  echo "[$(date)] WARNING: Could not enable NTP; checking existing clock synchronization"
-fi
-# Try NTP first
-for attempt in {1..6}; do
-  if timedatectl show -p NTPSynchronized --value 2>/dev/null | grep -q "yes"; then
-    echo "[$(date)] Clock synchronized via NTP"
-    break
-  fi
-  sleep 5
-done
-# Fallback: sync from HTTP header if NTP didn't work
-if ! timedatectl show -p NTPSynchronized --value 2>/dev/null | grep -q "yes"; then
-  if HTTP_DATE=$(curl -fsSI --max-time 10 https://deb.debian.org | sed -n 's/^[Dd]ate: //p' | tr -d '\r') &&
-    [ -n "$HTTP_DATE" ] && date -s "$HTTP_DATE" >/dev/null; then
-    echo "[$(date)] Clock synchronized via HTTP"
-  else
-    echo "[$(date)] WARNING: Clock synchronization unavailable"
-  fi
-fi
-
-# Install required packages
-export DEBIAN_FRONTEND=noninteractive
-echo "[$(date)] Installing packages..."
-for attempt in {1..3}; do
-  if apt-get update -qq 2>&1; then
-    break
-  fi
-  if [ "$attempt" -eq 3 ]; then
-    echo "[$(date)] apt-get update failed after 3 attempts"
-    exit 1
-  fi
-  echo "[$(date)] apt-get update failed (attempt $attempt/3), retrying in 10s..."
-  sleep 10
-done
-for attempt in {1..3}; do
-  if apt-get install -y -qq qemu-guest-agent podman uidmap slirp4netns curl wget; then
-    break
-  fi
-  if [ "$attempt" -eq 3 ]; then
-    echo "[$(date)] apt-get install failed after 3 attempts"
-    exit 1
-  fi
-  echo "[$(date)] apt-get install failed (attempt $attempt/3), retrying in 10s..."
-  sleep 10
-done
-systemctl enable --now qemu-guest-agent
-echo "[$(date)] Packages installed"
-
-# Setup swap (2GB)
-if [ ! -f /swapfile ]; then
-  fallocate -l 2G /swapfile
-  chmod 600 /swapfile
-  mkswap /swapfile
-  swapon /swapfile
-  echo '/swapfile none swap sw 0 0' >> /etc/fstab
-  echo "[$(date)] Swap file created"
-fi
-
-# Run UniFi OS installer
-if [ -f /opt/unifi-os-server.bin ]; then
-  cd /opt
-  ./unifi-os-server.bin <<<'y'
-  rm -f /opt/unifi-os-server.bin
-  echo "[$(date)] UniFi OS Server installed successfully"
-else
-  echo "[$(date)] ERROR: /opt/unifi-os-server.bin not found"
-  exit 1
-fi
-
-echo "[$(date)] First-boot setup complete"
-FBEOF
-
-vm_prepare_cloud_image "$FILE" "$HN"
-
-vm_customize "UniFi OS installer" "$FILE" \
-  --upload "unifi-os-server.bin:/opt/unifi-os-server.bin" \
-  --chmod 0755:/opt/unifi-os-server.bin \
-  --run-command "systemctl enable ssh" || exit 1
-
-vm_firstboot_unit "$FILE" "unifi-os-firstboot" "$FIRSTBOOT_SCRIPT" \
-  --description "UniFi OS Server First Boot Installer" \
-  --after qemu-guest-agent.service \
-  --requires-path /opt/unifi-os-server.bin \
-  --cloud-init yes || exit 1
-
-rm -f "$FIRSTBOOT_SCRIPT" "unifi-os-server.bin"
-msg_ok "Disk image customized (UniFi OS ${UOS_VERSION} staged for first-boot install)"
-
-vm_claim_vmid
-msg_info "Creating UniFi OS VM"
-qm create "$VMID" -agent 1${MACHINE} -tablet 0 -bios ovmf \
-  ${CPU_TYPE} -cores "$CORE_COUNT" -memory "$RAM_SIZE" \
-  -name "$HN" -tags community-script \
-  -net0 virtio,bridge="$BRG",macaddr="$MAC""$VLAN""$MTU" \
-  -onboot 1 -ostype l26 -scsihw virtio-scsi-pci
-vm_mark_created
-vm_import_disk "$VMID" "$FILE" "$STORAGE" "$DISK_IMPORT_FORMAT"
-
-qm set "$VMID" \
-  -efidisk0 "${STORAGE}:0,efitype=4m" \
-  -scsi0 "${VM_IMPORTED_DISK},${DISK_CACHE}size=${DISK_SIZE}" \
-  -boot order=scsi0 -serial0 socket >/dev/null
-vm_resize_disk
-qm set "$VMID" --agent enabled=1 >/dev/null
-
-vm_provision "$VMID"
-# Core currently suppresses SSH-key write errors; keep them fatal for this VM.
-if [[ -n "${CLOUDINIT_SSH_KEYS:-}" ]]; then
-  qm set "$VMID" --sshkeys "$CLOUDINIT_SSH_KEYS" >/dev/null
-fi
-
-set_description
-
-msg_ok "Created a UniFi OS VM ${CL}${BL}(${HN})"
-
-VM_IP=""
-UNIFI_READY=""
-FIRSTBOOT_DONE=""
-if [ "$START_VM" == "yes" ]; then
-  vm_start_vm "UniFi OS VM"
-  vm_wait_for_ip 360 || true
-
-  if [[ -n "${VM_FIRSTBOOT_MARKER:-}" ]] && vm_guest_exec "$VMID" 10 test -f "$VM_FIRSTBOOT_MARKER" >/dev/null; then
-    FIRSTBOOT_DONE="yes"
-  else
-    msg_warn "UniFi OS first-boot installation has not completed yet"
-  fi
-
-  if [[ -n "${VM_IP:-}" ]] && vm_wait_http "https://${VM_IP}:11443" 300 --insecure; then
-    UNIFI_READY="yes"
-    msg_ok "UniFi OS is up at https://${VM_IP}:11443"
-  elif [[ -n "${VM_IP:-}" ]]; then
-    msg_warn "UniFi OS is not ready; first-boot installation may still be running or may have failed"
-  fi
-else
-  msg_info "Start VM ${VMID} to run the UniFi OS first-boot installation"
-fi
-
-vm_print_summary \
-  "Operating System=${OS_DISPLAY}" \
-  "UniFi OS Version=${UOS_VERSION}" \
-  "Web Interface=https://${VM_IP:-<VM-IP>}:11443" \
-  "Console Login=${CLOUDINIT_USER:-root}"
-
-if [[ "$UNIFI_READY" == "yes" ]]; then
-  vm_next_steps \
-    "Open https://${VM_IP}:11443 and complete UniFi OS setup."
-  FINISH_MESSAGE="UniFi OS Server VM is ready."
-else
-  vm_next_steps \
-    "Wait for first-boot installation to complete in the VM: journalctl -u unifi-os-firstboot.service" \
-    "Follow progress in /var/log/unifi-os-install.log inside the VM." \
-    "Open https://${VM_IP:-<VM-IP>}:11443 after the installer finishes."
-  if [[ "$FIRSTBOOT_DONE" == "yes" ]]; then
-    FINISH_MESSAGE="VM provisioning completed; UniFi OS is installed, but web readiness was not confirmed yet."
-  else
-    FINISH_MESSAGE="VM provisioning completed; UniFi OS installation continues in the VM on first boot."
-  fi
-fi
-vm_finish "$FINISH_MESSAGE"

vm/zimaos-vm.sh

@@ -1,126 +0,0 @@
-#!/usr/bin/env bash
-
-# Copyright (c) 2021-2026 community-scripts ORG
-# Author: MickLesk (CanbiZ)
-# License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
-# Source: https://github.com/IceWhaleTech/ZimaOS
-
-COMMUNITY_SCRIPTS_URL="${COMMUNITY_SCRIPTS_URL:-https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main}"
-source <(curl -fsSL "${COMMUNITY_SCRIPTS_CORE_URL:-https://raw.githubusercontent.com/community-scripts/core/main}/pve/vm-core.func")
-load_functions
-
-APP="ZimaOS"
-APP_TYPE="vm"
-NSAPP="zimaos-vm"
-var_os="zimaos"
-var_version=" "
-GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
-METHOD=""
-THIN="discard=on,ssd=1,"
-
-header_info
-echo -e "\n Loading..."
-
-set -Eeo pipefail
-shopt -s inherit_errexit
-trap 'error_handler $LINENO "$BASH_COMMAND"' ERR
-trap cleanup EXIT
-trap 'post_update_to_api "failed" "130"' SIGINT
-trap 'post_update_to_api "failed" "143"' SIGTERM
-trap 'post_update_to_api "failed" "129"; exit 129' SIGHUP
-
-vm_require_arch amd64
-
-TEMP_DIR=$(mktemp -d)
-pushd "$TEMP_DIR" >/dev/null
-
-vm_preflight
-
-function default_settings() {
-  VMID=$(get_valid_nextid)
-  vm_apply_machine_type "q35"
-  DISK_SIZE="64G"
-  DISK_CACHE=""
-  HN="zimaos"
-  CPU_TYPE=" -cpu host"
-  CORE_COUNT="4"
-  RAM_SIZE="4096"
-  BRG="vmbr0"
-  MAC="$GEN_MAC"
-  VLAN=""
-  MTU=""
-  START_VM="yes"
-  METHOD="default"
-  vm_echo_default_settings
-}
-
-function advanced_settings() {
-  METHOD="advanced"
-  vm_prompt_vmid "${VMID:-$(get_valid_nextid)}"
-  vm_prompt_machine_type "q35"
-  vm_prompt_disk_size "64G" "Set Disk Size in GiB (Recommended: 64+ for apps)"
-  vm_prompt_disk_cache "none"
-  vm_prompt_hostname "zimaos"
-  vm_prompt_cpu_model "host"
-  vm_prompt_cpu_cores "4"
-  vm_prompt_ram "4096"
-  vm_prompt_bridge "vmbr0"
-  vm_prompt_mac "$GEN_MAC"
-  vm_prompt_vlan
-  vm_prompt_mtu
-  vm_prompt_keyboard
-  vm_prompt_verbose "no"
-  vm_prompt_start_vm "yes"
-
-  if vm_confirm_advanced_settings "Ready to create a ZimaOS VM?"; then
-    echo -e "${CREATING}${BOLD}${DGN}Creating a ZimaOS VM using the above advanced settings${CL}"
-  else
-    header_info
-    echo -e "${ADVANCED}${BOLD}${RD}Using Advanced Settings${CL}"
-    advanced_settings
-  fi
-}
-
-vm_start_script "Use Default Settings?\n\nDefaults:\n• 4 CPU Cores (Host model)\n• 4 GB RAM\n• 64 GB Disk\n• Q35 Machine Type" 14 58
-post_to_api_vm
-
-vm_select_storage "$HN"
-
-msg_info "Retrieving the URL for the ZimaOS installer"
-if ! vm_release_asset github IceWhaleTech/ZimaOS 'zimaos-x86_64-.*_installer\.iso$'; then
-  exit 1
-fi
-URL="$VM_RELEASE_URL"
-FILENAME="$VM_RELEASE_ASSET"
-ZIMAOS_VERSION="$VM_RELEASE_VERSION"
-var_version="$ZIMAOS_VERSION"
-vm_select_iso_storage "$FILENAME" "$HN"
-CACHE_FILE="$ISO_PATH"
-msg_ok "ZimaOS ${CL}${BL}${ZIMAOS_VERSION}${CL}"
-
-[[ -s "$CACHE_FILE" ]] || msg_warn "Downloading the ZimaOS installer (approximately 2 GB, this may take a while)"
-# Official installers such as 1.8.0-beta2 are smaller than 2 GiB.
-MIN_ISO_BYTES=$((1024 * 1024 * 1024))
-vm_fetch_image "$URL" "$CACHE_FILE" --cache --min-bytes "$MIN_ISO_BYTES" --sha256 "$VM_RELEASE_SHA256" || exit 115
-
-vm_claim_vmid
-msg_info "Creating a ZimaOS VM"
-$STD qm create $VMID -agent 1${MACHINE} -tablet 0 -bios ovmf${CPU_TYPE} -cores $CORE_COUNT -memory $RAM_SIZE \
-  -name $HN -tags community-script -net0 virtio,bridge=$BRG,macaddr=$MAC$VLAN$MTU -onboot 1 -ostype l26 -scsihw virtio-scsi-single \
-  -efidisk0 ${STORAGE}:1,efitype=4m,pre-enrolled-keys=0 -scsi0 ${STORAGE}:${DISK_SIZE%G},${DISK_CACHE}${THIN%,} \
-  -cdrom "$ISO_VOLUME" -boot order='scsi0;ide2' -vga std -serial0 socket
-vm_mark_created
-set_description
-msg_ok "Created a ZimaOS VM ${CL}${BL}(${HN})"
-
-vm_start_vm "ZimaOS VM"
-vm_print_summary "Version=${ZIMAOS_VERSION}" "ISO=${FILENAME}" "Discovery=https://find.zimaspace.com"
-vm_next_steps \
-  "Open the VM Console in Proxmox." \
-  "Follow the installer and select scsi0 as the target disk." \
-  "When prompted to remove the disk and reboot, reboot; the boot order prefers the disk." \
-  "Detach the ISO afterwards (Hardware -> CD/DVD -> Remove)." \
-  "Read the IP from the Proxmox summary once the guest agent is up, or use https://find.zimaspace.com." \
-  "For NAS use, add a second disk in Proxmox and let ZimaOS manage it."
-vm_finish "VM created; complete the ZimaOS installation in the Proxmox console."